I know. I just reverted my non-completed fix.
I leave this to cserve2 manager. ------------------------------------ -Regards, Hermet- -----Original Message----- From: "Gustavo Sverzut Barbieri"<[email protected]> To: "Enlightenment Development"<[email protected]>; Cc: "enlightenment-svn"<[email protected]>; Sent: 2012-11-11 (일) 06:51:21 Subject: Re: [E-devel] E SVN: hermet IN trunk: efl/src/bin/evas efl/src/modules/evas/loaders/gif evas/src/bin evas/src/modules/loaders/gif These are the wrong fix. The return must be checked, otherwise they will start another warning of unused result :-/ On Sat, Nov 10, 2012 at 9:35 AM, Enlightenment SVN < [email protected]> wrote: > Log: > evas/jpeg, cserve2 - removed unused > > > > Author: hermet > Date: 2012-11-10 03:35:42 -0800 (Sat, 10 Nov 2012) > New Revision: 79094 > Trac: http://trac.enlightenment.org/e/changeset/79094 > > Modified: > trunk/efl/src/bin/evas/evas_cserve2_slaves.c > trunk/efl/src/modules/evas/loaders/gif/evas_image_load_gif.c > trunk/evas/src/bin/evas_cserve2_slaves.c > trunk/evas/src/modules/loaders/gif/evas_image_load_gif.c > > Modified: trunk/efl/src/bin/evas/evas_cserve2_slaves.c > =================================================================== > --- trunk/efl/src/bin/evas/evas_cserve2_slaves.c 2012-11-10 > 11:18:27 UTC (rev 79093) > +++ trunk/efl/src/bin/evas/evas_cserve2_slaves.c 2012-11-10 > 11:35:42 UTC (rev 79094) > @@ -320,7 +320,6 @@ > _slave_proc_path_get(const char *name) > { > char buf[PATH_MAX], cwd[PATH_MAX]; > - char *ret; > > if (name[0] == '/') > { > @@ -329,7 +328,7 @@ > return eina_stringshare_add(name); > } > > - ret = getcwd(cwd, sizeof(cwd)); > + getcwd(cwd, sizeof(cwd)); > snprintf(buf, sizeof(buf), "%s/%s", cwd, name); > if (!access(buf, X_OK)) > return eina_stringshare_add(buf); > @@ -454,7 +453,6 @@ > _slave_thread_cb(void *data) > { > ssize_t n; > - int ret; > Slave_Command cmd; > > Slave_Thread_Data *sd = data; > @@ -477,7 +475,7 @@ > continue; > } > sd->cmdanswer = sd->cb(sd, &cmd, sd->cmddata, sd->cb_data); > - ret = write(sd->write_fd, &cmd, sizeof(cmd)); > + write(sd->write_fd, &cmd, sizeof(cmd)); > > n = read(sd->read_fd, &cmd, sizeof(cmd)); > } > > Modified: trunk/efl/src/modules/evas/loaders/gif/evas_image_load_gif.c > =================================================================== > --- trunk/efl/src/modules/evas/loaders/gif/evas_image_load_gif.c > 2012-11-10 11:18:27 UTC (rev 79093) > +++ trunk/efl/src/modules/evas/loaders/gif/evas_image_load_gif.c > 2012-11-10 11:35:42 UTC (rev 79094) > @@ -577,13 +577,10 @@ > GifRecordType rec; > int gra_res = 0, img_res = 0; > Eina_Bool res = EINA_FALSE; > - Gif_Frame *gif_frame = NULL; > > if ((!gif) || (!frame)) return EINA_FALSE; > - gif_frame = (Gif_Frame *) frame->info; > - > if (type > LOAD_FRAME_DATA_INFO) return EINA_FALSE; > - > + > do > { > if (DGifGetRecordType(gif, &rec) == GIF_ERROR) return EINA_FALSE; > @@ -631,23 +628,13 @@ > static Eina_Bool > evas_image_load_file_data_gif_internal(Image_Entry *ie, Image_Entry_Frame > *frame, int *error) > { > - int w; > - int h; > - int dst_x; > - int dst_y; > DATA32 *dst; > DATA32 *src; > int cache_w, cache_h; > size_t siz; > - Gif_Frame *gif_frame = NULL; > > - gif_frame = (Gif_Frame *) frame->info; > cache_w = ie->w; > cache_h = ie->h; > - w = gif_frame->image_des.w; > - h = gif_frame->image_des.h; > - dst_x = gif_frame->image_des.x; > - dst_y = gif_frame->image_des.y; > > src = frame->data; > > @@ -979,7 +966,6 @@ > int fd; > GifFileType *gif; > GifRecordType rec; > - int done; > int current_frame = 1; > int remain_frames = frame_num; > double duration = 0; > @@ -991,8 +977,6 @@ > if ((start_frame + frame_num) > frame_count) return -1; > if (frame_num < 0) return -1; > > - done = 0; > - > #ifndef __EMX__ > fd = open(file, O_RDONLY); > #else > > Modified: trunk/evas/src/bin/evas_cserve2_slaves.c > =================================================================== > --- trunk/evas/src/bin/evas_cserve2_slaves.c 2012-11-10 11:18:27 UTC > (rev 79093) > +++ trunk/evas/src/bin/evas_cserve2_slaves.c 2012-11-10 11:35:42 UTC > (rev 79094) > @@ -320,7 +320,6 @@ > _slave_proc_path_get(const char *name) > { > char buf[PATH_MAX], cwd[PATH_MAX]; > - char *ret; > > if (name[0] == '/') > { > @@ -329,7 +328,7 @@ > return eina_stringshare_add(name); > } > > - ret = getcwd(cwd, sizeof(cwd)); > + getcwd(cwd, sizeof(cwd)); > snprintf(buf, sizeof(buf), "%s/%s", cwd, name); > if (!access(buf, X_OK)) > return eina_stringshare_add(buf); > @@ -454,7 +453,6 @@ > _slave_thread_cb(void *data) > { > ssize_t n; > - int ret; > Slave_Command cmd; > > Slave_Thread_Data *sd = data; > @@ -477,7 +475,7 @@ > continue; > } > sd->cmdanswer = sd->cb(sd, &cmd, sd->cmddata, sd->cb_data); > - ret = write(sd->write_fd, &cmd, sizeof(cmd)); > + write(sd->write_fd, &cmd, sizeof(cmd)); > > n = read(sd->read_fd, &cmd, sizeof(cmd)); > } > > Modified: trunk/evas/src/modules/loaders/gif/evas_image_load_gif.c > =================================================================== > --- trunk/evas/src/modules/loaders/gif/evas_image_load_gif.c 2012-11-10 > 11:18:27 UTC (rev 79093) > +++ trunk/evas/src/modules/loaders/gif/evas_image_load_gif.c 2012-11-10 > 11:35:42 UTC (rev 79094) > @@ -577,13 +577,10 @@ > GifRecordType rec; > int gra_res = 0, img_res = 0; > Eina_Bool res = EINA_FALSE; > - Gif_Frame *gif_frame = NULL; > > if ((!gif) || (!frame)) return EINA_FALSE; > - gif_frame = (Gif_Frame *) frame->info; > - > if (type > LOAD_FRAME_DATA_INFO) return EINA_FALSE; > - > + > do > { > if (DGifGetRecordType(gif, &rec) == GIF_ERROR) return EINA_FALSE; > @@ -631,23 +628,13 @@ > static Eina_Bool > evas_image_load_file_data_gif_internal(Image_Entry *ie, Image_Entry_Frame > *frame, int *error) > { > - int w; > - int h; > - int dst_x; > - int dst_y; > DATA32 *dst; > DATA32 *src; > int cache_w, cache_h; > size_t siz; > - Gif_Frame *gif_frame = NULL; > > - gif_frame = (Gif_Frame *) frame->info; > cache_w = ie->w; > cache_h = ie->h; > - w = gif_frame->image_des.w; > - h = gif_frame->image_des.h; > - dst_x = gif_frame->image_des.x; > - dst_y = gif_frame->image_des.y; > > src = frame->data; > > @@ -979,7 +966,6 @@ > int fd; > GifFileType *gif; > GifRecordType rec; > - int done; > int current_frame = 1; > int remain_frames = frame_num; > double duration = 0; > @@ -991,8 +977,6 @@ > if ((start_frame + frame_num) > frame_count) return -1; > if (frame_num < 0) return -1; > > - done = 0; > - > #ifndef __EMX__ > fd = open(file, O_RDONLY); > #else > > > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_nov > _______________________________________________ > enlightenment-svn mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
