who added aborts again?!


------------------------------------

-Regards, Hermet-

-----Original Message-----
From: "Carsten Haitzler"<[email protected]> 
To: "Enlightenment developer 
list"<[email protected]>; 
Cc: <[email protected]>; 
Sent: 2012-11-13 (화) 00:05:51
Subject: Re: [E-devel] E SVN: raster IN trunk/efl/src: lib/evas/canvas 
modules/evas/engines/gl_x11

On Mon, 12 Nov 2012 14:52:22 +0000 Michael Blumenkrantz
<michael.blumenkrantz>@gmail.com> said:

well i had my e crashing on startup. i've been hammering on these issue for a
lot of today... in between trying to find a bug in drm/dri/mesa/xorg/kernel...
beats me where it is atm... but i need to get other bugs out of the way so i
can find it.

> I believe you confused "added NULL checks" with "removed abort()s"
> 
> On Mon, Nov 12, 2012 at 2:45 PM, Enlightenment SVN <
> [email protected]> wrote:
> 
> > Log:
> > more null checks in evas to avoid segs.
> >
> >
> >
> > Author:       raster
> > Date:         2012-11-12 06:45:07 -0800 (Mon, 12 Nov 2012)
> > New Revision: 79167
> > Trac:         http://trac.enlightenment.org/e/changeset/79167
> >
> > Modified:
> >   trunk/efl/src/lib/evas/canvas/evas_clip.c
> > trunk/efl/src/modules/evas/engines/gl_x11/evas_engine.c
> >
> > Modified: trunk/efl/src/lib/evas/canvas/evas_clip.c
> > ===================================================================
> > --- trunk/efl/src/lib/evas/canvas/evas_clip.c   2012-11-12 14:44:30 
UTC
> > (rev 79166)
> > +++ trunk/efl/src/lib/evas/canvas/evas_clip.c   2012-11-12 14:45:07 
UTC
> > (rev 79167)
> > @@ -219,26 +219,22 @@
> >     if (clip->delete_me)
> >       {
> >          CRIT("Setting deleted object %p as clip obj %p", eo_clip, 
eo_obj);
> > -        abort();
> >          return;
> >       }
> >     if (obj->delete_me)
> >       {
> >          CRIT("Setting object %p as clip to deleted obj %p", eo_clip,
> > eo_obj);
> > -        abort();
> >          return;
> >       }
> >     if (!obj->layer)
> >       {
> >          CRIT("No evas surface associated with object (%p)", eo_obj);
> > -        abort();
> >          return;
> >       }
> >     if ((obj->layer && clip->layer) &&
> >         (obj->layer->evas != clip->layer->evas))
> >       {
> >          CRIT("Setting object %p from Evas (%p) to another Evas (%p)",
> > obj, obj->layer->evas, clip->layer->evas);
> > -        abort();
> >          return;
> >       }
> >
> >
> > Modified: trunk/efl/src/modules/evas/engines/gl_x11/evas_engine.c
> > ===================================================================
> > --- trunk/efl/src/modules/evas/engines/gl_x11/evas_engine.c     
2012-11-12
> > 14:44:30 UTC (rev 79166)
> > +++ trunk/efl/src/modules/evas/engines/gl_x11/evas_engine.c     
2012-11-12
> > 14:45:07 UTC (rev 79167)
> > @@ -1939,7 +1939,7 @@
> >                          ERR("Try glXCreatePixmap on GLX with no 
support");
> >                        if (n->glx_pixmap)
> >                          {
> > -//                           printf("%p: new native texture for %x | 
%4i
> > x %4i @ %2i = %p\n",
> > +//                          printf("%p: new native texture for %x | 
%4i x
> > %4i @ %2i = %p\n",
> >  //                                  n, pm, w, h, depth, 
n->glx_pixmap);
> >                             if (!target)
> >                               {
> >
> >
> >
> > 
------------------------------------------------------------------------------
> > Everyone hates slow websites. So do we.
> > Make your web apps faster with AppDynamics
> > Download AppDynamics Lite for free today:
> > http://p.sf.net/sfu/appdyn_d2d_nov
> > _______________________________________________
> > enlightenment-svn mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >
> 
------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_nov
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    [email protected]


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to