Hello. On 19/11/12 14:53, Stefan Schmidt wrote: > Hello. > > On 19/11/12 14:22, Lucas De Marchi wrote: >> On Mon, Nov 19, 2012 at 11:22 AM, Stefan Schmidt <[email protected]> >> wrote: >>> Hello. >>> >>> On 19/11/12 13:10, Enlightenment SVN wrote: >>>> Log: >>>> evas: Fix shadow warnings >>>> >>>> x1, x2 shadow something in the math library. >>>> >>>> Would probably be better to turn off -Wshadow, but for some >>>> reason people think this there's some value in it... >>> >>> I agree that the x1, x2, y1, etc warnings from the math lib are >>> annoying. Sometimes the shadow warnings show problematic code though. >>> >>> I'm open for suggesting what warning flags we want to have as default >>> for buildbot. If people agree (I know there is no such thing as >>> universal agreement here on the list) that we should just skip -Wshadow >>> I'm fine with changing the buildbot builds that way. >> >> >> Use a compile that works fine with that option? There's no reason for >> a compiler to throw a warning if a variable named "x2" shadows a >> function or another entity. gcc >= 4.7 seems to get this right (I'm >> not sure which exactly version that became true, but I think it's gcc >> 4.7 indeed). >> >> Related rant from Linus back in 2006: https://lkml.org/lkml/2006/11/28/239 >> >> However it seems to be fixed in gcc now, so I think we can let people >> with older compilers to see the warnings and have the benefits brought >> by -Wshadow > > Thanks to my local Gentoo expert we now switched the buildslave from gcc > 4.6.3 to 4.7.1. Lets see what that changes.
It did cut down some of the noise. The x1, y1, etc warnings for example are gone now. Some other shadow things stay. I just leave it as is for now. regards Stefan Schmidt ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
