On 11/20/2012 06:55 PM, Gustavo Sverzut Barbieri wrote: > looking at evas/edje/elm: > > - Evas_Object_Smart: shouldn't it be NO INSTANT? Maybe in the future when > people use Eo to create sub-classes as opposed to extending > Evas_Smart_Class? We let it for compatibility with existent entities using smart, like e entities. In my opinion, we need to let it regular for backward compatibility forever or at least a lot of time. > - elm_widget: NO INSTANT, just compat will be REGULAR. You are right, will be fixed. FYI no more compat because no one was supposed to inherit from elm object before the porting. > - elm_box should share something with evas box, now that we have eo, same > for table > - elm_layout should share with edje > - elm_image, elm_thumb could share with evas_image > > Particularly I think that elm_widget should be an interface and not a > class, then you compose an elm_image from Evas_Object_Image with > Elm_Widget. There is no need to have the Evas_Smart as we do have now, it's > just there because we lacked tools. > > Also some others could be made mixin, file-selector button is both a file > selector and a button to launch it. Same for fileselector. > > I know some of my suggestions will require deeper changes and may not be > doable right now, but it's good to keep in mind. We focused for the moment on the Eo porting without changes on the design. And I don't want to imagine rebase ;-). More, we don't have enough deep knowledge to know what is supposed to be a mixin ... (as you wrote just before) so I think help will be needed from "outside" to do it. We already thought about file_selector_button change, the others were not obvious for us. Thank you for the tip. Too, we will create a new interface for item management because a lot of classes have the same item management operations (behavior is different but a common API can be found). > > As for the overall picture, it seems correct, but I did not compare it with > other references so I may have missed something. Great work! :-) Sure Glima will find the failures ;-) > > > > > > On Tue, Nov 20, 2012 at 2:09 PM, Yakov Goldberg <yako...@samsung.com> wrote: > >> Hi! >> As you probably know, we've (TAsn, JackDanielZ and me) ported Ecore, Evas >> and Edje to Eo and continuing working on Elementary. >> I'm also writing automatic bindings generator. >> >> First step I do: I parse C-sources and create XML for each class I've >> found. >> Later I generate code for Python(Cython based) and JS(elev8 - based). >> >> I also can build class diagram. No one, except JackDanielZ and TAsn never >> seen it. >> >> Now it's time to uncover it. :)) >> It would be nice, if you can take a look on it and tell us, if you see >> something wrong or strange in existing class hierarchy. >> >> PS. png is generated from graphviz directed graph. It would be nice to >> hear from you, if you know how I can make this diagram prettier. >> >> Yakov. >> >> >> ------------------------------------------------------------------------------ >> Monitor your physical, virtual and cloud infrastructure from a single >> web console. Get in-depth insight into apps, servers, databases, vmware, >> SAP, cloud infrastructure, etc. Download 30-day Free Trial. >> Pricing starts from $795 for 25 servers or applications! >> http://p.sf.net/sfu/zoho_dev2dev_nov >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> >
------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
