I checked with revision 79529 and it still happended. You can check it as below: - In Entry 3 of Elementary Tests, click at the end of the first entry, right click, choose Select, double click, right click to see the menu. You can see Copy, Paste, Cancel submenus there. - You can do the same way with an empty entry.
The reason is that we set the sd->have_selection to true at the start of selection (in elm_entry.c), even after that, the edje entry _sel_extend return without emitting "selection,changed" signal. Could you check it again? Best Regards, Thiep Ha ------- Original Message ------- Sender : Tom Hacohen<t...@stosb.com> Date : Nov 22, 2012 04:17 (GMT+09:00) Title : Re: [E-devel] [patch][elementary][entry] Hide copy/paste menu if there is no selection On Mon, Nov 19, 2012 at 12:33 PM, thiep ha <thiep...@samsung.com> wrote: > Dear All, > > I have seen that if there is no selection in an entry, the copy/cut menus > are still shown in entry. > (Example: double click at the end of entry or on an empty entry). > I modified source code to not show copy/cut menus in above scenario. > I also removed the redundant checking condition for showing copy/cut menus. > Please review this patch. > I can't test it atm, but I was under the impression it was already there. More specifically, I remember fixing it up a bit when I was working on ecrire. Are you certain it's broken? Maybe you've tested with old code? (Again, I can't test). -- Tom. ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel <p> </p><p> </p> ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
