On Mon, Nov 12, 2012 at 7:42 PM, Vincent Torri <[email protected]> wrote: > On Mon, Nov 12, 2012 at 11:05 AM, Enlightenment SVN > <[email protected]> wrote: >> Log: >> add support for and use eina_list_last_data_get >> >> Author: discomfitor >> Date: 2012-11-12 02:05:09 -0800 (Mon, 12 Nov 2012) >> New Revision: 79144 >> Trac: http://trac.enlightenment.org/e/changeset/79144 >> >> Modified: >> trunk/e/src/bin/e.h trunk/e/src/bin/e_flowlayout.c trunk/e/src/bin/e_fm.c >> trunk/e/src/bin/e_gadcon.c trunk/e/src/bin/e_randr_12_crtc.c >> trunk/e/src/bin/e_shelf.c trunk/e/src/bin/e_widget_toolbar.c >> trunk/e/src/modules/conf_randr/e_smart_monitor.c >> trunk/e/src/modules/gadman/e_mod_main.c >> trunk/e/src/modules/ibar/e_mod_main.c >> trunk/e/src/modules/quickaccess/e_mod_quickaccess.c >> >> Modified: trunk/e/src/bin/e.h >> =================================================================== >> --- trunk/e/src/bin/e.h 2012-11-12 10:00:08 UTC (rev 79143) >> +++ trunk/e/src/bin/e.h 2012-11-12 10:05:09 UTC (rev 79144) >> @@ -239,6 +239,10 @@ >> } \ >> } >> >> +#ifndef eina_list_last_data_get >> +# define eina_list_last_data_get(X) eina_list_data_get(eina_list_last(X)) >> +#endif > > imho, that's bad. Better put a FIXME saying that after the release, we > should use that new API (which is missing @since, btw...), instead of > depending on using that new API, even if it is defined.
I completely agree with you on this. -- Cedric BAIL ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
