Hi,
On Mon, Nov 26, 2012 at 11:35 PM, Leandro Dorileo
<dori...@profusion.mobi> wrote:
> Hi Cedric,
>
> On Mon, Nov 26, 2012 at 05:23:15PM +0900, Cedric BAIL wrote:
>> Yop,
>>
>> On Wed, Nov 21, 2012 at 2:42 AM, Leandro Dorileo <dori...@profusion.mobi>
>> wrote:
>> > What happens if a group has 2 name statements("double named")?
>> > edje will fail to free the groups cache while shuting down due
>> > the collection directory entry hash having two entries with
>> > different names but pointing to the same object - the second try
>> > to free the part mem pool will fail - since it was freed before -
>> > and issue an abort.
>> >
>> > Attached goes a patch to fix the issue.
>>
>> Just got back from vacation and reading your patch. Wouldn't
>> current_de->entry be set to something != NULL, before the parse_str(0)
>> call ? If that's the case, it would be a way better patch in my
>> opinion.
>
> I'm not sure if I correctly understand your suggestion but current_de->entry
> *is*
> something != NULL. What the patch does is try to find if current_de is already
> in in the edje_file->collection.
My understanding is that if the group is already in the hash,
current_de->entry should already be defined to something before the
parse_str(0) call. So instead of walking all the hash (that may be
slow), we could just check at the entry point of the function if
current_de->entry != NULL. I am just not sure how this work with
inheritance. So that's why you get a question there :-)
> What currently happens is that the same current_de is been added twice case a
> group is
> "double named" - two name statements for the same group. This behavior
> doesn't look
> correct to me.
I agree on that.
--
Cedric BAIL
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
