On Thu, Dec 6, 2012 at 11:02 AM, Gustavo Sverzut Barbieri <[email protected]> wrote: > On Thu, Dec 6, 2012 at 10:33 AM, Vincent Torri <[email protected]> > wrote: >> On Thu, Dec 6, 2012 at 1:26 PM, Enlightenment SVN >> <[email protected]> wrote: >>> Log: >>> Avoid calling test so many times. Use -a/-o instead. >> >> as i have already said, it can break on some shells and the autotools >> prefer what i have done than what you are doing. Excerpt : >> >> test >> The test program is the way to perform many file and string tests. >> It is often invoked by the alternate name ‘[’, but using that name in >> Autoconf code is asking for trouble since it is an M4 quote character. >> >> The -a, -o, ‘(’, and ‘)’ operands are not present in all >> implementations, and have been marked obsolete by Posix 2008. This is >> because there are inherent ambiguities in using them. For example, >> ‘test "$1" -a "$2"’ looks like a binary operator to check whether two >> strings are both non-empty, but if ‘$1’ is the literal ‘!’, then some >> implementations of test treat it as a negation of the unary operator >> -a. >> >> from >> http://www.gnu.org/software/autoconf/manual/autoconf.html#Limitations-of-Builtins >> >> So revert... > > I disagree here, given that we never use the first operand as ! in any > of our checks, just yes/no, there is no harm. The benefit is reducing > the number of calls to test binary and also the resulting code size as > it's smaller. > > as for not being present, could you point a real case other than an > imaginary case? I never saw that and we already had some of that in > our efl before, so it should work. >
I reverted mostly due to the fact of "have been marked obsolete by Posix 2008". -- Eduardo de Barros Lima ◤✠◢ [email protected] ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
