On 12/12/2012 03:02 PM, Michael Blumenkrantz wrote: > stupid though it may seem, released #defines indeed cannot be changed
I guess I could have seen that. Will fix in another way then. Thanks for spotting Daniel > On Wed, Dec 12, 2012 at 2:55 PM, Vincent Torri <vincent.to...@gmail.com>wrote: > >> isn't this an API break ? >> >> On Wed, Dec 12, 2012 at 3:49 PM, Enlightenment SVN >> <no-re...@enlightenment.org> wrote: >>> Log: >>> eet: Fix possible buffer overflow in functions relying on EET_T_LAST. >>> >>> Issue reported by Klocwork. Backport, ChangeLog, NEWS included >>> >>> Signed-off-by: Daniel Willmann <d.willm...@samsung.com> >>> >>> Author: asdfuser >>> Date: 2012-12-12 06:49:49 -0800 (Wed, 12 Dec 2012) >>> New Revision: 80767 >>> Trac: http://trac.enlightenment.org/e/changeset/80767 >>> >>> Modified: >>> branches/eet-1.7/ChangeLog branches/eet-1.7/NEWS >> branches/eet-1.7/src/lib/Eet.h trunk/efl/ChangeLog trunk/efl/NEWS >> trunk/efl/src/lib/eet/Eet.h >>> >>> Modified: branches/eet-1.7/ChangeLog >>> =================================================================== >>> --- branches/eet-1.7/ChangeLog 2012-12-12 14:44:10 UTC (rev 80766) >>> +++ branches/eet-1.7/ChangeLog 2012-12-12 14:49:49 UTC (rev 80767) >>> @@ -651,3 +651,7 @@ >>> 2012-12-11 Cedric Bail >>> >>> * Fix leak eet_pbkdf2_sha1 with OpenSSL. >>> + >>> +2012-12-12 Daniel Willmann >>> + >>> + * Fix possible buffer overflow in functions relying on >> EET_T_LAST. >>> >>> Modified: branches/eet-1.7/NEWS >>> =================================================================== >>> --- branches/eet-1.7/NEWS 2012-12-12 14:44:10 UTC (rev 80766) >>> +++ branches/eet-1.7/NEWS 2012-12-12 14:49:49 UTC (rev 80767) >>> @@ -5,6 +5,7 @@ >>> >>> Fixes: >>> * Fix memory leak when using OpenSSL for ciphering long data. >>> + * Fix possible buffer overflow in functions relying on EET_T_LAST >>> >>> Eet 1.7.3 >>> >>> >>> Modified: branches/eet-1.7/src/lib/Eet.h >>> =================================================================== >>> --- branches/eet-1.7/src/lib/Eet.h 2012-12-12 14:44:10 UTC (rev >> 80766) >>> +++ branches/eet-1.7/src/lib/Eet.h 2012-12-12 14:49:49 UTC (rev >> 80767) >>> @@ -2366,7 +2366,7 @@ >>> #define EET_T_F32P32 14 /**< Data type: fixed point 32.32 */ >>> #define EET_T_F16P16 15 /**< Data type: fixed point 16.16 */ >>> #define EET_T_F8P24 16 /**< Data type: fixed point 8.24 */ >>> -#define EET_T_LAST 18 /**< Last data type */ >>> +#define EET_T_LAST 17 /**< Last data type */ >>> >>> #define EET_G_UNKNOWN 100 /**< Unknown group data encoding type >> */ >>> #define EET_G_ARRAY 101 /**< Fixed size array group type */ >>> >>> Modified: trunk/efl/ChangeLog >>> =================================================================== >>> --- trunk/efl/ChangeLog 2012-12-12 14:44:10 UTC (rev 80766) >>> +++ trunk/efl/ChangeLog 2012-12-12 14:49:49 UTC (rev 80767) >>> @@ -1,3 +1,7 @@ >>> +2012-12-12 Daniel Willmann >>> + >>> + * Fix possible buffer overflow in functions relying on >> EET_T_LAST. >>> + >>> 2012-12-12 Cedric Bail >>> >>> * Add ellipsis support in Evas_Object_Text. >>> >>> Modified: trunk/efl/NEWS >>> =================================================================== >>> --- trunk/efl/NEWS 2012-12-12 14:44:10 UTC (rev 80766) >>> +++ trunk/efl/NEWS 2012-12-12 14:49:49 UTC (rev 80767) >>> @@ -76,3 +76,4 @@ >>> * Fixed polygon rendering bug in GL backend when there are cutouts. >>> * Fix leak in eet_pbkdf2_sha1 with OpenSSL. >>> * Fix the gl line incorrect position drawing. >>> + * Fix possible buffer overflow in functions relying on EET_T_LAST >>> >>> Modified: trunk/efl/src/lib/eet/Eet.h >>> =================================================================== >>> --- trunk/efl/src/lib/eet/Eet.h 2012-12-12 14:44:10 UTC (rev 80766) >>> +++ trunk/efl/src/lib/eet/Eet.h 2012-12-12 14:49:49 UTC (rev 80767) >>> @@ -2401,7 +2401,7 @@ >>> #define EET_T_F32P32 14 /**< Data type: fixed point 32.32 */ >>> #define EET_T_F16P16 15 /**< Data type: fixed point 16.16 */ >>> #define EET_T_F8P24 16 /**< Data type: fixed point 8.24 */ >>> -#define EET_T_LAST 18 /**< Last data type */ >>> +#define EET_T_LAST 17 /**< Last data type */ >>> >>> #define EET_G_UNKNOWN 100 /**< Unknown group data encoding type >> */ >>> #define EET_G_ARRAY 101 /**< Fixed size array group type */ >>> >>> >>> >> ------------------------------------------------------------------------------ >>> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial >>> Remotely access PCs and mobile devices and provide instant support >>> Improve your efficiency, and focus on delivering more value-add services >>> Discover what IT Professionals Know. Rescue delivers >>> http://p.sf.net/sfu/logmein_12329d2d >>> _______________________________________________ >>> enlightenment-svn mailing list >>> enlightenment-...@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >> >> >> ------------------------------------------------------------------------------ >> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial >> Remotely access PCs and mobile devices and provide instant support >> Improve your efficiency, and focus on delivering more value-add services >> Discover what IT Professionals Know. Rescue delivers >> http://p.sf.net/sfu/logmein_12329d2d >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > ------------------------------------------------------------------------------ > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel