Hi,

after spamming IRC channel with this patch I decided to let it rot
here.

On my mandriva builds I found that EFL configure script accepts
--x-includes parameter but it is handling wrong.

if you run `./configure --x-includes=/usr/include', it will break on
missing XKB. In fact gcc command will fail because additional
`/usr/include' is present on command line.

Patch makes it `-I/usr/include' which seems to be intended, but not
implemented.

I verified by googling a bit --x-includes always got directory and
never -I/some/dir.

Cheers,

Tomas Cech
Sleep_Walker
From edd84300582d1b53a6b8acd1170bc18e3f1a88ae Mon Sep 17 00:00:00 2001
From: =?utf8?q?Tom=C3=A1=C5=A1=20=C4=8Cech?= <sleep_wal...@suse.cz>
Date: Tue, 11 Dec 2012 00:48:45 +0100
Subject: [PATCH] fix cflags for the case that x_includes in not empty
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit


Signed-off-by: Tomáš Čech <sleep_wal...@suse.cz>
---
 efl/m4/ecore_check_c_extension.m4 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/efl/m4/ecore_check_c_extension.m4 b/efl/m4/ecore_check_c_extension.m4
index 9918a4b..f6e88ac 100644
--- a/efl/m4/ecore_check_c_extension.m4
+++ b/efl/m4/ecore_check_c_extension.m4
@@ -4,7 +4,7 @@ AC_DEFUN([ECORE_CHECK_X_EXTENSION],
 pushdef([UP], translit([$1], [a-z], [A-Z]))dnl
 
   SAVE_CFLAGS=$CFLAGS
-  CFLAGS="$x_cflags $x_includes"
+  CFLAGS="$x_cflags ${x_includes:+-I${x_includes}}"
   AC_CHECK_HEADER(X11/extensions/$2,
     [
      AC_CHECK_LIB($3, $4,
-- 
1.7.10.4


Attachment: signature.asc
Description: Digital signature

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to