On Mon, 17 Dec 2012 19:40:01 +0100 "hannes.janet...@gmail.com" <hannes.janet...@googlemail.com> wrote:
> On Mon, Dec 17, 2012 at 6:13 PM, Enlightenment SVN > <no-re...@enlightenment.org> wrote: > > Log: > > arghhh this damn typo took me an hour of ecore internal debugging to find! > > damn you jeffdameth!!! > > > > > > Author: discomfitor > > Date: 2012-12-17 09:13:35 -0800 (Mon, 17 Dec 2012) > > New Revision: 81166 > > Trac: http://trac.enlightenment.org/e/changeset/81166 > > > > Modified: > > trunk/e/src/modules/everything/evry_view.c > > > > Modified: trunk/e/src/modules/everything/evry_view.c > > =================================================================== > > --- trunk/e/src/modules/everything/evry_view.c 2012-12-17 16:19:40 UTC > > (rev 81165) > > +++ trunk/e/src/modules/everything/evry_view.c 2012-12-17 17:13:35 UTC > > (rev 81166) > > @@ -577,8 +577,6 @@ > > if (sd->idle_enter) > > ecore_idle_enterer_del(sd->idle_enter); > > > > - _animator_del(obj); > > - > > free(sd); > > evas_object_smart_data_set(obj, NULL); > > } > > @@ -953,7 +951,7 @@ > > e_scrollframe_child_pos_set(sd->view->sframe, 0, sd->scroll_align); > > > > sd->place = EINA_TRUE; > > - _e_smart_reconfigure_do(obj); > > + _e_smart_reconfigure(obj); > > > > _pan_item_select(obj, sd->cur_item, 0); > > > > not a typo actually. which issue was caused by this? iirc forcing > reconfigure was required to have the scrollframe positioned correctly > when switching icon/list modes > > well calling this function outside of the idler is broken in 100% of cases that I tested; you always have an idler existing, and you are guaranteed to lose track of that idler by calling this function. ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
