Hello.

On 18/12/12 13:52, daniel.za...@samsung.com wrote:
> On 12/18/2012 03:22 PM, Stefan Schmidt wrote:
>> Hello.
>>
>> On 18/12/12 12:41, daniel.za...@samsung.com wrote:
>>> I removed this macro already and committed.
>>> Btw, DATA_GET was already defined ... just two lines after ;-)
>> But that still could deliver NULL so the part to check for NULL before
>> dereferencing it and crash is still needed, right? Just wondering.
> Yes, it can. Checking NULL is always needed but not always done, that is
> the problem. There are a lot of code in EFL that retrieves data and
> doesn't check nullity, even before Eo.

Yup. Don't wanted to make that your fault. Just checking that we 
actually need to check before accessing them. So my original patch still 
makes sense in some cases.

Glima, could you check the patch in the original mail and see if I got 
the logic wrong. (In cases where we would get NULL)

regards
Stefan Schmidt


------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to