On Sun, 23 Dec 2012 11:04:36 +0900 Carsten Haitzler (The Rasterman) <[email protected]> wrote:
> On Sun, 23 Dec 2012 01:49:24 +0000 Michael Blumenkrantz > <[email protected]> said: > > > On Sun, 23 Dec 2012 10:45:40 +0900 > > Carsten Haitzler (The Rasterman) <[email protected]> wrote: > > > > > On Sat, 22 Dec 2012 10:09:34 -0800 "Enlightenment SVN" > > > <[email protected]> said: > > > > > > ummm... this actually first isn't a bug - use xterm. it pastes the > > > newline. > > > so you've actually broken functionality compared with "the originl > > > terminal > > > emulator"" (well from my pov xterm is the bar to meet function-wise, and > > > then improve from there, and here i can't double-click a line of a command > > > and just middle click past to run it .. newline included). > > > > > > so compare xterm vs terminology before and after this patch. you'll see > > > what i mean. > > > > > > > Log: > > > > terminology: remove trailing newline when selecting text. Fix #1967 > > > > > > > > Patch by Panagiotis Galatsanos <galatsanosp at gmail com> > > > > > > > > Author: billiob > > > > Date: 2012-12-22 10:09:17 -0800 (Sat, 22 Dec 2012) > > > > New Revision: 81644 > > > > Trac: http://trac.enlightenment.org/e/changeset/81644 > > > > > > > > Modified: > > > > trunk/terminology/src/bin/termio.c > > > > > > > > Modified: trunk/terminology/src/bin/termio.c > > > > =================================================================== > > > > --- trunk/terminology/src/bin/termio.c 2012-12-22 16:29:50 UTC (rev > > > > 81643) +++ trunk/terminology/src/bin/termio.c 2012-12-22 18:09:17 > > > > UTC (rev 81644) @@ -773,7 +773,16 @@ > > > > for (i = 0; i < ev->len; i++) > > > > { > > > > tmp[i] = s[i]; > > > > - if (tmp[i] == '\n') tmp[i] = '\r'; > > > > + if (tmp[i] == '\n') > > > > + { > > > > + // remove trailing new line > > > > + if (i != (ev->len - 2)) tmp[i] = '\r'; > > > > + else > > > > + { > > > > + tmp[i] = '\0'; > > > > + break; > > > > + } > > > > + } > > > > } > > > > termpty_write(sd->pty, tmp, ev->len - 1); > > > > free(tmp); > > > > the difference is that terminology adds the newline after a single extra > > selected character, xterm requires the whole line to be selected. the former > > is much more dangerous if you aren't 100% accurate with your selection, and > > imo it's also very unexpected > > in xterm when u drag your selection to the right of a "short line" it extends > TO the end of the ling (int erminology visually it doesnt, but it logicly > includes the newline put into the term)... and thus it pastes it. > > try it in xterm. if u arent very accurate there the selection just runs off to > the end of the line instantly after the char that is last on the line... and > it > pastes the newline. it's the same behavior as terminology effectively except > terminology doesnt DISPLy the selection to go all the way to the end of line. right, but that's still a huge difference in usability. in one situation you have to look closely to see if you've accidentally selected an extra character, in another you can easily tell. > > this patch is not the solution. it makes things exceedingly less useful and > more annoying. if anything then make the selection visually change to jump to > include the whole line. yes, this would be a better fix. > > but now... i can no longer copy & paste a line of text in terminology with the > newline included at the end - ever. in xterm i can. thisis VERY annoying for > all sorts of tasts - including programming and using the shell. > agreed ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
