On Tue, 25 Dec 2012 17:27:11 +0100 Maxime Villard <rusty...@gmx.fr> wrote:
> Hi, > here is a small patch for the shot module. > > 1) 'fsize' should be long, and doesn't need to be global (as 'fdata' ?) Yeah. All those static variables look weird. > 2) At l.475, we leak 'fd' > > 3) Error dialogs' titles should be simplified > > 4) Also added some strerror(errno) in error messages... Those error messages doesn't look consistent with other error messages in E. I don't know how they should look like, but i think that at list an output of strerror() should go after <br>. -- Igor > Tested on OpenBSD. > > Ok/Comments ? ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
