Thanks for your advice. 1. To use that item, needs additional "EINA_LIST_FOREACH" loop. If you are not concerned about it, Please review this attached patch. This patch fixed it follow your advice.
2. Applied. 3. I was confused. I've restored it. Please review again. Thanks. Jihyeon Seol -----Original Message----- From: Daniel Juyung Seo [mailto:seojuyu...@gmail.com] Sent: Thursday, December 27, 2012 6:20 PM To: Enlightenment developer list Subject: Re: [E-devel] [Patch] elm_index active issue Thanks for the patch but this patch needs more love. 1. adopting sd->selected_it Adopting sd->selected_it needs to be taken care a lot more love. elm_index already has it->selected. sd->selected_it also has to be changed when it->selected changes. So change sd->selected_it also when it->selected or it_closest->selected is changed. 2. if condition checks Change if (sd->selected_it != NULL) to if (sd->selected_it) That's what other efl codes do. 3. Elm_Index_Item Why did you move Elm_Index_Item structure position? Just curious... 4. Elm_Index_Item *selected_it inside Elm_Index_Item You added 'selected_it' to Elm_Index_Item and it looks better if you put selected_it ahead of 'Eina_Bool seleted'. So when another Eina_Bool is added later it will be packed with existing Eina_Bool. This does not break ABI. Thanks. Daniel Juyung Seo (SeoZ) On Thu, Dec 27, 2012 at 4:57 PM, Jihyeon Seol <jihyeon.s...@samsung.com>wrote: > Dear, all > > > This patch is for fix the index active issue that index item's "active" > status is changed to "inactive" after change of font size and so on. > > The problem is occurred by repetition of _elm_index_smart_theme(). > This function changes item's status to "inactive". > > I modified as follows: > When _elm_index_smart_theme() called repeatedly, if there's "active" > item, the item's status will be changed to "active". > > > Please review this patch. > > Sincerely, > Jihyeon Seol > > > ---------------------------------------------------------------------- > -------- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, > HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your > skills current with LearnDevNow - 3,200 step-by-step video tutorials > by Microsoft MVPs and experts. ON SALE this month only -- learn more > at: > http://p.sf.net/sfu/learnmore_122712 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ---------------------------------------------------------------------------- -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_122712 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
elm_index_active_issue.diff
Description: Binary data
------------------------------------------------------------------------------ Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and much more. Get web development skills now with LearnDevNow - 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122812
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
