Dear Daniel, I would like to send the modified source code. Please review it.
P/S: Sorry for a little late, my laptop was broken last night. Thanks & Regards, Thiep ------- Original Message ------- Sender : Daniel Juyung Seo<seojuyu...@gmail.com> Date : Jan 02, 2013 19:13 (GMT+09:00) Title : Re: [E-devel] [PATCH] [Elementary] Patch to fix elementary list with separator Oops Thiep, sorry I didn't review test_list.c So here are more comments. 1. api_data api_data *api = calloc(1, sizeof(api_data));$ api_data is not used in test_list_separator() so remove it and related codes. 2. test_list_separator(xxx) indentation Indentations for test_list_separator(xxx) are wrong. +test_list_separator(void *data __UNUSED__, + Evas_Object *obj __UNUSED__, + void *event_info __UNUSED__) Thanks. Daniel Juyung Seo (SeoZ) On Wed, Jan 2, 2013 at 6:53 PM, Daniel Juyung Seo <seojuyu...@gmail.com>wrote: > Dear Thiep, thanks a lot for your bug fix. > There was an explicit bug on elm list separator. > And I have some comments. > > 1. elementary-1.7 > Please support the same patches to elementary-1.7. > > 2. it->deleted checks > it->deleted checks in elm_list.c:600 is not needed. > It was already checked. > > 3. it->separator_themed > separator_themed is not needed. > it->fixed does the same job. > > 4. code structure > I think you can reuse some existing code. > Move 38 ~ 47 lines of your patch to the following parts and reuse the code. > if (!it->fixed) ... > If my explanation is ambigous I will do the refactoring once your code is > committed. > > Thanks. > > Daniel Juyung Seo (SeoZ) > > > On Sun, Dec 30, 2012 at 3:03 PM, Thiep Ha <thie...@gmail.com> wrote: > >> Hi all, >> >> I sent this patch before, but there is no reply. >> So, I resend it. >> Since separators in list are not correctly applied (always have same size >> with other items), >> this patch is sent to fix that. >> Could someone review it? >> >> Thanks, >> Thiep >> >> >> >> From: thiep ha <thiep...@samsung.com> >> > Date: Sun, Dec 9, 2012 at 11:11 AM >> > Subject: [E-devel] [Patch] [Elementary] Patch to fix elementary list >> with >> > separator >> > To: "enlightenment-devel@lists.sourceforge.net" < >> > enlightenment-devel@lists.sourceforge.net> >> > >> > >> > Dear All, >> > >> > In elementary list, the separator is not correctly set. >> > I would like to send a patch to correct the list with separator. >> > I also add an example named "List Separator" to test it. >> > >> > Please review this patch. >> > >> > Best Regards, >> > Thiep Ha >> > >> > >> >> >> ------------------------------------------------------------------------------ >> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >> MVPs and experts. ON SALE this month only -- learn more at: >> http://p.sf.net/sfu/learnmore_123012 >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> > ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel <p> </p><p> </p>
elm_list_separator.diff
Description: Binary data
elm_list_separator_1_7.diff
Description: Binary data
------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_122712
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
