Thanks raster for the review. I should have reviewed this long ago :( Daniel Juyung Seo (SeoZ)
On Thu, Jan 3, 2013 at 8:59 PM, Carsten Haitzler <ras...@rasterman.com>wrote: > On Wed, 28 Nov 2012 16:03:34 +0900 DUBEYPRINCE KUMAR < > prince.du...@samsung.com> > said: > > could you also provide a patch against "Stable 1.7" elm? this applies only > to > "trunk". also.. you should add more warnings to your cflags... your tests > were > broken and totally overran array bounds. i fixed it in the commit. :) > > > Hi, > > > > > > > > Please review the attached patches. > > > > Attached patch "elm_gengrid.patch" which fix the bug related to > > elm_gengrid_region_show/bring_in APIs. > > > > And patch "test_gengrid.patch" in order to test the fix. > > > > > > > > Change Description: > > > > 1. An internal function _item_show_region() is created which does the > > calculation for item position. > > > > 2. This function is called in _calc_job() as soon as pan object gets > its > > size. > > > > 3. Test_gengrid code enhancement for testing the fix. > > > > Signed-Off-By: PRINCE KUMAR DUBEY <prince.dubey>@samsung.com>. > > > > > > > > Thank You. > > > > > > > > Regards, > > > > Prince > > > > > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122712 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_122712 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
