On Thu, Jan 3, 2013 at 12:34 PM, Gustavo Sverzut Barbieri <barbi...@profusion.mobi> wrote: > Hi people, > > I'm reviewing the checks in efl/configure.ac and some are quite weird, > which I want to remove if there is no valid reason for their existence. > > IMO the way Evil, Escape and Exotic are done are a bit cumbersome for the > libraries to use. For instance, evil_libgen.h matches libgen.h, however the > user code must have the following: > > #ifdef HAVE_LIBGEN_H > #include <libgen.h> > #endif > ... > #ifdef HAVE_EVIL > #include <Evil.h> /* includes evil_libgen.h */ > #endif > > why not call evil_libgen.h just libgen.h and let the user include it > normally? We just -I$(top_srcdir)/src/lib/evil if building for Evil, then > it makes life simpler. > > In my mind Evil.h and Exotic. doesn't even need to exist... they could > exist in some cases where the system file exists but lacks something. > Say libgen.h in PS3 lacked basename, then we could have: > * escape_libgen.h: basename() definition > * Escape.h: includes escape_libgen.h to match complete libgen.h
or.... you use "#include_next <libgen.h>" inside Escape's libgen.h and don't bother with never ever creating Escape.h http://gcc.gnu.org/onlinedocs/cpp/Wrapper-Headers.html Not sure if other compilers support this, though Lucas De Marchi ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_122712 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
