Thank you for your advice :)
I took your advice and then I simply took the signal emit code out of the if
case.
Please review this patch again.
Thank you,
Jaehyun Cho.
-----Original Message-----
From: "Daniel Juyung Seo"<seojuyu...@gmail.com>
To: "Enlightenment developer
list"<enlightenment-devel@lists.sourceforge.net>;
Cc:
Sent: 2013-01-06 (일) 16:09:44
Subject: Re: [E-devel] [Patch] Fix elc_naviframe to emit state signals for text
part (elementary)
Thanks. Good catch but these lines are already there so you can reuse it.
+ eina_stringshare_replace(&pair->part, part);
+ if (label)
+ snprintf(buf, sizeof(buf), "elm,state,%s,show", part);
+ else
+ snprintf(buf, sizeof(buf), "elm,state,%s,hide", part);
+ elm_object_signal_emit(VIEW(it), buf, "elm");
Can you provide a better patch?
Daniel Juyung Seo (SeoZ)
On Sun, Jan 6, 2013 at 2:23 PM, 조재현 <jae_hyun_cho>@naver.com> wrote:
> Dear all,
>
> Hello. This is Jaehyun Cho.
> Now, naviframe emits state signals (e.g. show or hide) for customized text
> part (i.e. neither "elm.text.title" nor "elm.text.subtitle") which is going
> to be appended to the item's text_list.
> However, if the customized text parts change the text label when the text
> parts are in the item's text_list, naviframe does not emit state signals
> for them.
> To resolve this issue, I added additional case in _item_text_set_hook to
> handle the text part which is in the item's text_list.
> (elementary/src/lib/elc_naviframe.c)
> Please review this.
>
> Thank you,
> Jaehyun Cho.
>
>
>
------------------------------------------------------------------------------
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_123012
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Index: src/lib/elc_naviframe.c
===================================================================
--- src/lib/elc_naviframe.c (revision 82299)
+++ src/lib/elc_naviframe.c (working copy)
@@ -396,12 +396,12 @@
eina_stringshare_replace(&pair->part, part);
nit->text_list = eina_inlist_append(nit->text_list,
EINA_INLIST_GET(pair));
- if (label)
- snprintf(buf, sizeof(buf), "elm,state,%s,show", part);
- else
- snprintf(buf, sizeof(buf), "elm,state,%s,hide", part);
- elm_object_signal_emit(VIEW(it), buf, "elm");
}
+ if (label)
+ snprintf(buf, sizeof(buf), "elm,state,%s,show", part);
+ else
+ snprintf(buf, sizeof(buf), "elm,state,%s,hide", part);
+ elm_object_signal_emit(VIEW(it), buf, "elm");
elm_object_part_text_set(VIEW(it), part, label);
}
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
