Summary: remove Xlib.h but take care and use longs where xlib does it. On Tuesday, January 8, 2013, Carsten Haitzler wrote:
> On Mon, 7 Jan 2013 21:12:58 -0200 Gustavo Sverzut Barbieri > <[email protected] <javascript:;>> said: > > > Why does Evas_Engine_GL_X11.h includes Xlib.h and use its types > > while Evas_Engine_Software_X11.h defines as generic types (int, void > *...) > > > > I was reviewing ecore_evas_x.c that binds Ecore_X with Ecore_Evas and why > > it would need ECORE_X_CFLAGS from Joel to find about this. > > > > IMO we should change GL_X11.h to use generic types and avoid such CFLAGS. > > But it may cause warnings for people not using Ecore_Evas. These warnings > > are harmless. > > > > What do you say? > > i think this is a historical oddity. sw_x11 actually became generic and > "xlib > free" because it does BOTH xcb ANd xlib... and this it uses a void * for > connections and ptrs when needed and otherwise unsigned int (32bit value to > store a window id etc. as x PROTOCOL defines these as being 32bits). i > think > it'd be good for gl_x11.hg to also do that sw_x11 did... BUT... we have a > problem... to maintain abi.. we have to use unsigned long for drawable and > colormap... as historically xlib has used long for these (and thus often > 64bit > issues with properties etc. as we get 32bit values stuffed in an array of > longs... 64 bit values). > > > -- > > Gustavo Sverzut Barbieri > > http://profusion.mobi embedded systems > > -------------------------------------- > > MSN: [email protected] <javascript:;> > > Skype: gsbarbieri > > Mobile: +55 (19) 9225-2202 > > > ------------------------------------------------------------------------------ > > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > > MVPs and experts. SALE $99.99 this month only -- learn more at: > > http://p.sf.net/sfu/learnmore_122412 > > _______________________________________________ > > enlightenment-devel mailing list > > [email protected] <javascript:;> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] <javascript:;> > > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
