Should i change default mode to do screen actions on fullscreen windows? I think that check might come from the old days when the presentation mode wasn't available. So in the end i could completly remove this option and don't check for fullscreen windows - if the user unlocks too fast, he will get a screen telling him to enable presentation mode...
On 01/08/2013 03:36 AM, Carsten Haitzler (The Rasterman) wrote: > On Tue, 08 Jan 2013 08:35:42 +1030 Simon <si...@simotek.net> said: > >> On 01/08/2013 02:43 AM, Enlightenment SVN wrote: >>> Log: >>> Don't blank on fullscreen windows (as we don't run the screenlock on >>> fullscreen windows). Check all zones for fullscreen windows. >> I think this should be more intelligent, screenlock as well. On my work >> PC i generally run a IDE and a couple of virtual machines fullscreen and >> would still like screenlock to apply (Its company IT policy and means i >> can disable it on my windows VM). At home on my laptop the only thing >> that ever gets run fullscreen is VLC so i would be happy to apply it >> here. I thought that this was the whole point of presentation mode to >> disable the screensaver and screen blanking while watching a movie if >> you just broadly apply it to all fullscreen windows there is almost no >> point to presentation mode. It would be better to block it on a >> application level or not at all in my opinion. For me the best solution >> would be something along the lines of a list off applications or window >> remembers that automatically toggle presentation mode. So when i launch >> say VLC presentation mode is enabled, when i close it presentation mode >> is disabled. >> Cheers, >> Simon > i happen to agree - screen dimming and blanking and lock shouldn't just be > blanket disabled for all fullscreen windows. presentation mode is there for > that. media players do things like suspend screensaver themselves if they are > well behaved and in "fullscreen mode" and the user wants it etc. > > that reminds me that there is this awesome issue gnome/gtk people have been > dealing with.. or not -f or years. screenlock doesn't work if a menu is up.. > since menus grab kbd/mouse - this is a universal (not gnome specific issue). > reality is - screenlocks SHOULD work regardless of such menu states or > fullscreen window states - by default. screen blanking/dimming etc. too. only > when a user EXPLICITLY does not want it for that window/app - then it should > be > able to be disabled... i'm fine with a global policy checkbox too that is a > "disable blanking for all fullscreen windows" (and off by default) etc. > > and that brings me to a much uglier issue - the popup menu kbd grab/lock... > there isn't a lot to be done here without there being either: > > 1. a heuristic to determining which client has the gram and figuring out the > window with the grab and closing it to force it to be released. (kind of > hard). > 2. toolkits/clients agreeing not to use key/mouse grabs and using regular > window focus (that is a.. well.. interesting thing as wm's now need to play > nice as this window has to follow a different focus policy to normal windows > as > its a popup window/menu etc.). this still doesn't fix clients/toolktis that > don't play nice > 3. a real x extension api to break a key/mouse grab so the unlock dialog can > work > 4. just ignore this problem and hope we all use wayland sooner which will fix > it. > > right now though - this is an academic discussion as i don't intend to try and > fix it... enough stuff to do :) > >>> Author: morlenxus >>> Date: 2013-01-07 08:13:17 -0800 (Mon, 07 Jan 2013) >>> New Revision: 82354 >>> Trac: http://trac.enlightenment.org/e/changeset/82354 >>> >>> Modified: >>> trunk/e/src/bin/e_screensaver.c >>> >>> Modified: trunk/e/src/bin/e_screensaver.c >>> =================================================================== >>> --- trunk/e/src/bin/e_screensaver.c 2013-01-07 15:44:23 UTC (rev >>> 82353) +++ trunk/e/src/bin/e_screensaver.c 2013-01-07 16:13:17 UTC >>> (rev 82354) @@ -32,10 +32,11 @@ >>> int timeout = 0, count = (1 + _e_screensaver_ask_presentation_count); >>> >>> if ((e_config->screensaver_enable) && (!e_config->mode.presentation) >>> && >>> - (!e_util_fullscreen_current_any())) >>> + (!e_util_fullscreen_any())) >>> timeout = e_config->screensaver_timeout * count; >>> >>> - if ((use_idle) && (!e_config->mode.presentation)) >>> + if ((use_idle) && (!e_config->mode.presentation) && >>> + (!e_util_fullscreen_any())) >>> { >>> if (e_config->backlight.idle_dim) >>> { >>> >>> >>> ------------------------------------------------------------------------------ >>> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >>> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >>> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >>> MVPs and experts. SALE $99.99 this month only -- learn more at: >>> http://p.sf.net/sfu/learnmore_122412 >>> _______________________________________________ >>> enlightenment-svn mailing list >>> enlightenment-...@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >> >> ------------------------------------------------------------------------------ >> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >> MVPs and experts. SALE $99.99 this month only -- learn more at: >> http://p.sf.net/sfu/learnmore_122412 >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > ------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel