Hello, this patch looks cool and in SVN but I have some comments. http://trac.enlightenment.org/e/changeset/82845
1. indentation. The indentation between EFL c sources and EDC are different. EDC uses 3 spcaes for indentation. You don't need to change it. It's already ok. I fixed indentations in your patch. 2. NEWS and ChangeLog This is a bug fix. Please provide NEWS and ChangeLog patches next time. I did it for you this time. 3. Branches backport. Please provide a backport for e/branches/elementary-1.7 next time. I did it for you this time. Thanks. Daniel Juyung Seo (SeoZ) On Tue, Jan 15, 2013 at 6:02 PM, SHILPA ONKAR SINGH < shilpa.si...@samsung.com> wrote: > > Hi All, > > Please find attached bug fix for elm_check - toggle style. > This patch prevents "changed" signal being sent twice in case of > toggle style when check is clicked. > This also fixes few indentation issues in the style. > > Change description: > elm_check: Bug fix "changed" signal being sent twice in case of toggle > style when check is clicked. > > Signed-Off by: Rajeev Ranjan(rajee...@samsung.com) > Signed-Off by: Shilpa Singh(shilpa.si...@samsung.com) > > Thanks & Regards > Shilpa Singh > > ------------------------------------------------------------------------------ > Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS > and more. Get SQL Server skills now (including 2012) with LearnDevNow - > 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. > SALE $99.99 this month only - learn more at: > http://p.sf.net/sfu/learnmore_122512 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
