On Sat, 26 Jan 2013 04:43:55 +0100 Leif Middelschulte <[email protected]> said:
> Am Samstag, 26. Januar 2013 um 03:41 schrieb Carsten Haitzler: > > On Fri, 25 Jan 2013 20:32:43 +0100 Leif Middelschulte > > <[email protected] (mailto:[email protected])> said: > > > > > Hi guys, > > > > > > while trying to get efl (seperate libraries) and elementary packaged > > > upstream for homebrew package manager (Mac OS), I came over a bug in > > > edje_cc that was causing the compilation of elm's theme to fail. > > > > > > It seems that edje_cc uses edje's binary prefix to execute embryo, which > > > is wrong. I'm not sure whether it should rely on PATH or use embryo's > > > pkg-config value. Since it uses eina_prefix now, I assume a runtime > > > dynamic version is preferred. The problematic line is the following: > > > http://trac.enlightenment.org/e/browser/trunk/IN-EFL/edje/src/bin/edje_cc_out.c#L1331 > > > > > > > > > it HAS to do this as it can't rely on knowing embryo's prefix. it assumes > > embryo is put int he same prefix as edje - that is its assumption. as of the > > efl merged tree.. this is 100% correct too. :) > > > > > > So why not rely on PATH or pkg-config? Taking some other package's prefix and > assuming it has to be the same seem's odd. Also, maybe a differentiating > error message ("executable not found") would be useful here. pkg-config is at compile-time only. efl can be relocated at runtime. PATH requires people set up their path then to work which they invariably dont eg if things are in /opt etc. as i said - its moot anyway - they ARE in the same prefix anyway now - by force. they come from the same build tree which uses a single prefix for everything. > > > For now, I'll just add a patch for edje to its homebrew formula. > > > > > > I hope we can fix this in the next release. > > > > > > -- > > > > > > Leif > > > > > > ------------------------------------------------------------------------------ > > > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > > > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > > > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > > > MVPs and experts. ON SALE this month only -- learn more at: > > > http://p.sf.net/sfu/learnnow-d2d > > > _______________________________________________ > > > enlightenment-devel mailing list > > > [email protected] > > > (mailto:[email protected]) > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) [email protected] > > (mailto:[email protected]) > > > > > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnnow-d2d > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
