Hi Bora,
Hyoyoung made a good comment.
Please split the formatting fix and other patches.
Actually this is not a formatting fix. It was wrong.

Please refer the following links:
http://trac.enlightenment.org/e/wiki/PatchReview
http://trac.enlightenment.org/e/wiki/ECoding

Can you resend your patch?
Thanks.

Daniel Juyung Seo (SeoZ)

On Wed, Jan 30, 2013 at 11:36 PM, Hyoyoung Chang <hyoyo...@gmail.com> wrote:

> Hello, your patch is nice to apply. but indent isn't
> why you change indent heavily? i think it's better to customize your
> editor.
>
>
> On Wed, Jan 30, 2013 at 1:17 PM, Bora Hwang <bora1.hw...@samsung.com>
> wrote:
>
> > Dear all,
> >
> > In elc_ctxpopup.c, there's something wrong when calculating the position
> > of arrow.
> > According to the previous code, arrow cannot be shown in the right
> position
> > when it should not be displayed in the middle of the ctxpopup.
> >
> > After the value and condition of the calculation are changed,
> > user can put the arrow where he or she wants easily.
> > (As far as the position has appropriate value in the window)
> >
> > Thanks.
> >
> >
> ------------------------------------------------------------------------------
> > Everyone hates slow websites. So do we.
> > Make your web apps faster with AppDynamics
> > Download AppDynamics Lite for free today:
> > http://p.sf.net/sfu/appdyn_d2d_jan
> > _______________________________________________
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> >
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_jan
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to