2013/2/23 Carsten Haitzler <[email protected]>: > On Sat, 23 Feb 2013 21:03:02 +0900 Bluezery <[email protected]> said: > >> 2013/2/23 Carsten Haitzler <[email protected]>: >> > On Thu, 21 Feb 2013 18:48:42 +0900 Bluezery <[email protected]> said: >> > >> >> Hello, >> >> >> >> This patch fix 1byte invalid read error for char * string. >> >> Readed bytes needs one more bytes for NULL terminated char. >> > >> > could you try our new phab tool for submitting patches? see my comments >> > here: >> > >> > https://phab.enlightenment.org/D2 >> > >> > i want to try nut out phab with respect to review and actual patches (and >> > generating of them). >> >> >> I made it! arc is a good tool :) I think this can be better than gerrit. >> https://phab.enlightenment.org/D3 >> >> PS. It's better to add the ".arcconfig" file to .gitignore > > hmm it seems without a .arcconfig things are all bad. if i add one i cant make > things work as master has it but somenow patch branch doesnt as it is based on > an olkder rev. if i add one it conflicts etc. > > can u re-submit the same patch again please? really testing and trying to make > phab work for us... sorry about the "pain"... its initial. once i know how > this > works it should be smoother and i'll document it.
I made a patch again. https://phab.enlightenment.org/D10 I want to make a patchset on D3. I can't becauseD3 is already abandoned or arc doesn't support it. Patchset feature is important to log the review history. > >> > >> > -- >> > ------------- Codito, ergo sum - "I code, therefore I am" -------------- >> > The Rasterman (Carsten Haitzler) [email protected] >> > >> >> >> >> -- >> BRs, >> Kim. >> >> ------------------------------------------------------------------------------ >> Everyone hates slow websites. So do we. >> Make your web apps faster with AppDynamics >> Download AppDynamics Lite for free today: >> http://p.sf.net/sfu/appdyn_d2d_feb >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] > -- BRs, Kim. ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
