I think that our current naming convention would be to name it ecore_pipe_super_add ?
On Wed, Feb 27, 2013 at 12:20 PM, David Seikel <onef...@gmail.com> wrote: > On Wed, 27 Feb 2013 04:11:11 -0800 Cedric BAIL - Enlightenment Git > <no-re...@enlightenment.org> wrote: > > > cedric pushed a commit to branch master. > > > > commit 762163bb45e819f7a8668e51b6fbb7977896874f > > Author: Cedric BAIL <cedric.b...@samsung.com> > > Date: Mon Feb 25 09:32:27 2013 +0900 > > > > ecore: extend Ecore_Pipe API to make it more useful. > > > > This make it possible to take over a pipe that was open in > > another process and also prevent its destruction partially during > > exec. --- > > src/lib/ecore/Ecore.h | 7 +++++ > > src/lib/ecore/ecore_pipe.c | 72 > > +++++++++++++++++++++++++++++++++++----------- 2 files changed, 63 > > insertions(+), 16 deletions(-) > > > > diff --git a/src/lib/ecore/Ecore.h b/src/lib/ecore/Ecore.h > > index 2f44326..a44fbef 100644 > > --- a/src/lib/ecore/Ecore.h > > +++ b/src/lib/ecore/Ecore.h > > @@ -2830,10 +2830,17 @@ typedef struct _Ecore_Pipe Ecore_Pipe; /**< A > > handle for pipes */ typedef void (*Ecore_Pipe_Cb)(void *data, void > > *buffer, unsigned int nbyte); > > EAPI Ecore_Pipe *ecore_pipe_add(Ecore_Pipe_Cb handler, const void > > *data); +EAPI Ecore_Pipe *ecore_pipe_full_add(Ecore_Pipe_Cb handler, > > + const void *data, > > + int fd_read, int fd_write, > > + Eina_Bool read_survive_fork, > > + Eina_Bool write_survive_fork); > > Possibly not the best name. If some one wants to write another new > variation with more arguments, should they call it > ecore_pipe_fuller_add()? ecore_pipe_fullest_add()? > > Still in the middle of cooking, so I've not looked at the rest to see > what a better name might be. > > -- > A big old stinking pile of genius that no one wants > coz there are too many silver coated monkeys in the world. > > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_feb > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
