On Tue, 23 Apr 2013 11:32:15 +0900 Cedric BAIL <cedric.b...@free.fr> said:

> On Mon, Apr 22, 2013 at 11:55 PM, Carsten Haitzler  - Enlightenment
> Git <no-re...@enlightenment.org> wrote:
> > raster pushed a commit to branch master.
> >
> > commit 116013320a941357a925441928ea7e10ed6c0ebd
> > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
> > Date:   Tue Apr 23 00:05:59 2013 +0900
> >
> >     ummm dont set max based on max hint... this got added at some point
> >     but it actually breaks older code that used these hints to store
> >     sizing info but didnt expect it to be enforced.
> 
> That code was modified by you the 2009-10-08 and was originally
> written by rephorm the 2007-05-27. This is prior to any release. I
> have no idea what you are trying to fix, but this change is likely to
> cause more break than fix in my opinion. That code is present since
> our 1.0 release. Can you explain what code you are trying to fix ? And
> hwat behavior you see ?

backgrounds in e17. if you set a wallpaper whose images is smaller than the
screen it refuses to scale up because e17 has (forever) set the max entry as a
hint as to what the image size is natively before edje fiddles with it. as ther
are basically only 2 of these (min and max) there is pretty much little choice
as to what to set... i thought this was added much more recently. i didn't dig
in (i had a queue of people asking for my attention/help). i have actually seen
zero breaks... :)

> > ---
> >  src/lib/edje/edje_util.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/lib/edje/edje_util.c b/src/lib/edje/edje_util.c
> > index 27539da..a61010b 100644
> > --- a/src/lib/edje/edje_util.c
> > +++ b/src/lib/edje/edje_util.c
> > @@ -6287,10 +6287,10 @@ _edje_real_part_swallow_hints_update(Edje_Real_Part
> > *rp) edje_object_size_min_get(rp->typedata.swallow->swallowed_object, &w,
> > &h); rp->typedata.swallow->swallow_params.min.w = w;
> >          rp->typedata.swallow->swallow_params.min.h = h;
> > -#endif
> >          edje_object_size_max_get(rp->typedata.swallow->swallowed_object,
> > &w, &h); rp->typedata.swallow->swallow_params.max.w = w;
> >          rp->typedata.swallow->swallow_params.max.h = h;
> > +#endif
> >       }
> >     else if (eo_isa(rp->typedata.swallow->swallowed_object,
> > EVAS_OBJ_TEXT_CLASS) || eo_isa(rp->typedata.swallow->swallowed_object,
> > EVAS_OBJ_POLYGON_CLASS) ||
> >
> > --
> >
> > ------------------------------------------------------------------------------
> > Precog is a next-generation analytics platform capable of advanced
> > analytics on semi-structured data. The platform includes APIs for building
> > apps and a phenomenal toolset for data science. Developers can use
> > our toolset for easy data analysis & visualization. Get a free account!
> > http://www2.precog.com/precogplatform/slashdotnewsletter
> >
> 
> 
> 
> --
> Cedric BAIL
> 
> ------------------------------------------------------------------------------
> Precog is a next-generation analytics platform capable of advanced
> analytics on semi-structured data. The platform includes APIs for building
> apps and a phenomenal toolset for data science. Developers can use
> our toolset for easy data analysis & visualization. Get a free account!
> http://www2.precog.com/precogplatform/slashdotnewsletter
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to