On Thu, 25 Apr 2013 08:56:24 +0900 Cedric BAIL <cedric.b...@free.fr> said:
> On Thu, Apr 25, 2013 at 12:28 AM, Carsten Haitzler - Enlightenment
> Git <no-re...@enlightenment.org> wrote:
> > raster pushed a commit to branch master.
> >
> > commit 7dfe2c557372bfb7b6ce775e0230d0e893325481
> > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
> > Date: Thu Apr 25 00:31:31 2013 +0900
> >
> > add --with-api=XXX (both|legacy|eo) to define which api set to enable
> > by default (default == both).
>
> I do believe this is useless. No packager can turn that off at that
> level. Everyone that use Elementary can't turn that off. The way it is
> implemented make it just a way for us to feel good and not support the
> stability of Eo API/ABI. I do think, it should be an opt-in on a per
> application need. If Elementary want it, it should define the flag
> itself. If Expedite want it, it does the same. If a developer want it,
> it turn it on by himself in his application. Your solution is way more
> complex and doesn't provide anything that can be used by developers or
> packagers.
READ Efl_Config.h ... you'll find that your above comment is actually quite
wrong. :) it's explicitly DOCUMENTED to be wrong. :) the configure option sets
up the DEFAULT api unless overridden.
> > ---
> > configure.ac | 31 +++++++++++++++++++++++++++++++
> > src/lib/efl/Efl_Config.h.in | 9 ++++++++-
> > 2 files changed, 39 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index f8d1d9f..ce70d86 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -19,6 +19,36 @@ AC_USE_SYSTEM_EXTENSIONS
> > AM_INIT_AUTOMAKE([1.6 dist-bzip2 -Wall color-tests])
> > m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
> >
> > +#### Apply configuring with legacy api's only, eo api's or both.
> > +
> > +EFL_API_LEGACY_DEF="#define EFL_NOLEGACY_API_SUPPORT"
> > +EFL_API_EO_DEF="#define EFL_EO_API_SUPPORT"
> > +efl_api="both"
> > +
> > +AC_ARG_WITH([api],
> > + [AC_HELP_STRING([--with-api=@<:@eo/legacy/both@:>@], [Select the EFL
> > API Model @<:@default=both@:>@])],
> > + [efl_api=${withval}],
> > + [efl_api="both"])
> > +
> > +case "$efl_api" in
> > + eo)
> > + EFL_API_LEGACY_DEF="#define EFL_NOLEGACY_API_SUPPORT"
> > + EFL_API_EO_DEF="#define EFL_EO_API_SUPPORT"
> > + ;;
> > + legacy)
> > + EFL_API_LEGACY_DEF=""
> > + EFL_API_EO_DEF=""
> > + ;;
> > + both)
> > + EFL_API_LEGACY_DEF=""
> > + EFL_API_EO_DEF="#define EFL_EO_API_SUPPORT"
> > + ;;
> > + *) AC_MSG_ERROR([Invalid web backend: must be eo, legacy or both]) ;;
> > +esac
> > +
> > +AC_SUBST(EFL_API_LEGACY_DEF)
> > +AC_SUBST(EFL_API_EO_DEF)
> > +
> > #### Additional options to configure
> >
> > AC_ARG_WITH([profile],
> > @@ -3786,6 +3816,7 @@ else
> > fi
> >
> > echo "Configuration...: ${COLOR_OTHER}profile=${build_profile} os=${osname}
> > ${COLOR_RESET}" +echo " EFL API Set...: ${efl_api}"
> > echo " CPU Extensions: ${host_cpu} (${features_cpu})"
> > echo " System Feature: ${features_system}"
> > echo " Threads.......: ${efl_have_threads} (${features_thread})"
> > diff --git a/src/lib/efl/Efl_Config.h.in b/src/lib/efl/Efl_Config.h.in
> > index 30c18ae..e76c9e5 100644
> > --- a/src/lib/efl/Efl_Config.h.in
> > +++ b/src/lib/efl/Efl_Config.h.in
> > @@ -1,6 +1,13 @@
> > #ifndef EFL_CONFIG_H
> > #define EFL_CONFIG_H
> >
> > -#define XYXYXY 1
> > +/* Add -DEFL_API_OVERRIDE ot your CFLAGS to override the default
> > + * installed api set and then fter that -DEFL_NOLEGACY_API_SUPPORT
> > + * and/or -DEFL_EO_API_SUPPORT as desired
> > + */
> > +#ifndef EFL_API_OVERRIDE
> > +@EFL_API_LEGACY_DEF@
> > +@EFL_API_EO_DEF@
> > +#endif
> >
> > #endif
> >
> > --
> >
> > ------------------------------------------------------------------------------
> > Try New Relic Now & We'll Send You this Cool Shirt
> > New Relic is the only SaaS-based application performance monitoring service
> > that delivers powerful full stack analytics. Optimize and monitor your
> > browser, app, & servers with just a few lines of code. Try New Relic
> > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
> >
>
>
>
> --
> Cedric BAIL
>
> ------------------------------------------------------------------------------
> Try New Relic Now & We'll Send You this Cool Shirt
> New Relic is the only SaaS-based application performance monitoring service
> that delivers powerful full stack analytics. Optimize and monitor your
> browser, app, & servers with just a few lines of code. Try New Relic
> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) ras...@rasterman.com
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
