On 16/05/13 13:43, Eduardo Lima (Etrunko) wrote: > On Thu, May 16, 2013 at 3:01 AM, Christopher Michael > <[email protected]> wrote: >> Eduardo, >> >> The patch is simple enough. If it fixes the problem for you, then go >> ahead and push it. The wayland_egl engine is going to be rewritten at >> some point (when I find some time) to make use of evas_gl stuff, but if >> this fixes it for you then feel free to push it. > > > Alright, I'm pushing it later today. I was wondering if this was an > actual problem with the engine
Aside from being a bloody mess you mean ?? ;) or something I was doing wrong, but > looking at the code, there are actually some valid cases where re->win > can be NULL, so that should be checked. > Indeed. No worries with a push ;) dh > Regards, Etrunko >> >> dh >> >> On 15/05/13 20:56, Eduardo Lima (Etrunko) wrote: >>> From: "Eduardo Lima (Etrunko)" <[email protected]> >>> >>> Hi Devilhorns, >>> >>> I wanted to send this email to the mailing list before commiting because I >>> am a >>> bit confused of why this is crashing. Take a look on this backtrace >>> http://fpaste.org/12383/64474713/ >>> >>> The scenario is basically the normal of a Ecore_Evas application: >>> ecore_evas_new() -> ecore_evas_resize() -> ecore_evas_show() -> >>> ecore_mainloop_begin(). At some point there is a call to ecore_evas_hide(), >>> and >>> then, when I call ecore_evas_show() again, the application crashes. >>> >>> Regards, Etrunko >>> >>> Signed-off-by: Eduardo Lima (Etrunko) <[email protected]> >>> --- >>> src/modules/evas/engines/wayland_egl/evas_engine.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/src/modules/evas/engines/wayland_egl/evas_engine.c >>> b/src/modules/evas/engines/wayland_egl/evas_engine.c >>> index 0d9761a..0cd3ac6 100644 >>> --- a/src/modules/evas/engines/wayland_egl/evas_engine.c >>> +++ b/src/modules/evas/engines/wayland_egl/evas_engine.c >>> @@ -544,6 +544,7 @@ static int >>> _re_wincheck(Render_Engine *re) >>> { >>> if (!re) return 0; >>> + if (!re->win) return 0; >>> if (re->win->surf) return 1; >>> eng_window_resurf(re->win); >>> if (!re->win->surf) >>> @@ -761,7 +762,7 @@ eng_setup(Evas *eo_e, void *in) >>> if ((re->win) && (inc)) >>> re->win->gl_context->references--; >>> } >>> - } >>> + } >>> else if ((re->win->w != e->output.w) || >>> (re->win->h != e->output.h)) >>> { >>> >> >> ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
