On Mon, 27 May 2013 22:21:48 +0200 Davide Andreoli <d...@gurumeditation.it> said:
> 2013/5/21 Nicolas Aguirre <aguirre.nico...@gmail.com> > > > Hi there, > > please find attached a patch which introduce a new emotion API : > > emotion_module_option_get, which retrieves the parameters set with > > emotion_module_option_set. This patch also pass options to the engine. > > It's usefull in case of VLC to give specific arguments for example, > > the --no-video-title, it's annoying to have the name of the film > > displayed at statup. > > > > I'm not sure this is the best thing we ca do here, but it' doesn't > > break the "API" and it does the job, so please review. > > > > I'm not sure either that is the right way to go, but I also really need to > remove that annoying > title on the movies. Do you have other options to pass or is just the title > ? > > I think that the display of the title should be removed by default, no > other engines > have that and they should behave all the same way. So it should be easier > to just put > that option with the other defaults...but: 100% correct. the title should never have been rendered there. it's just an annoying default in libvlc where they overlay a title on the video. it should never have been there. we should be able to GET title from a video stream and display as an evas object somewhere if we want to - its up to the player/app not emotion itself to display this. subtitles are a grey area though. for dvd's subtitles literally are an image overlay in the ts - u dont have text, just bitmaps. dvd menu nav is done the same way. i wish dvd's never did this for subtitles ... but they did... so i think we have to live with this. > The way we pass options to vlc is wrong. We pass args to libvlc_new(), the > docs say: > > "There is absolutely no warranty or promise of forward, backward and > cross-platform compatibility with regards to > libvlc_new > ()<http://www.videolan.org/developers/vlc/doc/doxygen/html/group__libvlc__core.html#ga915aa5778053d7b52ff9f6ba6e2f7764>arguments. > We recommend that you do not use them, other than when debugging." > > So I'm not sure that option is supported by other libvlc versions...ideas ? i'd say we dont add this option api. just pass --no-video-title by default. imho any options should be as universal across modules as possible and should be maintained going forward for compat. > dave > > > > > > > > > There is also a patch for emotion_generic_players to pass such > > arguments to vlc generic player. > > > > Regards, > > -- > > Nicolas Aguirre > > Mail: aguirre.nico...@gmail.com > > Web: http://enna.geexbox.org > > Blog: http://dev.enlightenment.fr/~captainigloo/ > > > > > > ------------------------------------------------------------------------------ > > Try New Relic Now & We'll Send You this Cool Shirt > > New Relic is the only SaaS-based application performance monitoring service > > that delivers powerful full stack analytics. Optimize and monitor your > > browser, app, & servers with just a few lines of code. Try New Relic > > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > ------------------------------------------------------------------------------ > Try New Relic Now & We'll Send You this Cool Shirt > New Relic is the only SaaS-based application performance monitoring service > that delivers powerful full stack analytics. Optimize and monitor your > browser, app, & servers with just a few lines of code. Try New Relic > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
