On Thursday 30 May 2013 11:43, Carsten Haitzler wrote : > On Wed, 29 May 2013 19:07:33 -0500 Doug Newgard <scimmi...@outlook.com> said: > > > I helped figure out what was going on when the bug reporter came on IRC > > trying to figure out why his build failed. There was no pkgconfig file on > > his > > system, as you can see by his configure log: "checking whether PNG image > > loader will be built... no". That's why the question is being asked here, > > should the configure script fail without libpng or should it disable certain > > things that depend on libpng? > > as per my reply - it should, unless explicitly --disabled. same for jpeg, gif > and tiff.
just to be sure both options should be implemented ? - want_evas_image_loader_png=yes|static => crashes if not found (now all loaders crashes only if "yes" and not found) - want_evas_image_loader_png=no => build anyway thus add if HAVE_LOADER_PNG … endif in emotion_test, ethumb emotion module and edje examples same for jpeg, gif, and tiff > > > > > ---------------------------------------- > > > Date: Thu, 30 May 2013 08:55:33 +0900 > > > From: ras...@rasterman.com > > > To: enlightenment-devel@lists.sourceforge.net > > > CC: scimmi...@outlook.com > > > Subject: Re: [E-devel] compilation fail without png support > > > > > > On Wed, 29 May 2013 18:37:06 -0500 Doug Newgard <scimmi...@outlook.com> > > > said: > > > > > >> I think you missed the point, raster. The problem is that the configure > > >> script doesn't find the libpng .pc file, but continues to try to build > > >> anyway, resulting in a build failure. > > > > > > i thought it did but the header was missing? i thought we made png, jpeg, > > > tiff, gif mandatory (unless --disabled)? > > > > > >> ---------------------------------------- > > >>> Date: Thu, 30 May 2013 08:20:57 +0900 > > >>> From: ras...@rasterman.com > > >>> To: enlightenment-devel@lists.sourceforge.net > > >>> Subject: Re: [E-devel] compilation fail without png support > > >>> > > >>> On Wed, 29 May 2013 23:35:54 +0200 Jérémy Zurcher <jer...@asynk.ch> > > >>> said: > > >>> > > >>> i havent checked yet - seen the ticket though. as such if you have the > > >>> pc > > >>> file (pkg-config) but dont have the .h... your system is broken > > >>> regardless. we will fail compiling in a gazillion ways if deps behave > > >>> this way. we can't be expected to test every possible broken system > > >>> setup > > >>> (have pc file > > >>> - missing 1, 2, 3 or 4 headers? which permutation of headers is missing? > > >>> are we missing shared libs - should we test linking? what if the version > > >>> the pc advertises is not the version of the lib installed? shall we test > > >>> for every function symbol?). thus this is a low priority thing imho due > > >>> to > > >>> it seemingly just being a broken build system, but if there are any > > >>> sanity > > >>> checks they go in configure and we abort configure. the problem here is > > >>> that our configure just gets bigger and messier the more of these we > > >>> add. :( > > >>> > > >>>> Hi, > > >>>> as reported in https://phab.enlightenment.org/T64, > > >>>> without proper png support compilation crashes because of: > > >>>> - emotion_test > > >>>> - edje examples > > >>>> - ethumb emotion module > > >>>> > > >>>> what is the right way to handle this ? > > >>>> - crash configure > > >>>> - disable compilation of faulty bits > > >>>> > > >>>> I have patches ready for both of these options in > > >>>> https://phab.enlightenment.org/D133 > > >>>> > > >>>> Jérémy > > >>>> > > >>>> ------------------------------------------------------------------------------ > > >>>> Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET > > >>>> Get 100% visibility into your production application - at no cost. > > >>>> Code-level diagnostics for performance bottlenecks with <2% overhead > > >>>> Download for free and get started troubleshooting in minutes. > > >>>> http://p.sf.net/sfu/appdyn_d2d_ap1 > > >>>> _______________________________________________ > > >>>> enlightenment-devel mailing list > > >>>> enlightenment-devel@lists.sourceforge.net > > >>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >>> > > >>> > > >>> -- > > >>> ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > >>> The Rasterman (Carsten Haitzler) ras...@rasterman.com > > >>> > > >>> > > >>> ------------------------------------------------------------------------------ > > >>> Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET > > >>> Get 100% visibility into your production application - at no cost. > > >>> Code-level diagnostics for performance bottlenecks with <2% overhead > > >>> Download for free and get started troubleshooting in minutes. > > >>> http://p.sf.net/sfu/appdyn_d2d_ap1 > > >>> _______________________________________________ > > >>> enlightenment-devel mailing list > > >>> enlightenment-devel@lists.sourceforge.net > > >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >>> > > >> ------------------------------------------------------------------------------ > > >> Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET > > >> Get 100% visibility into your production application - at no cost. > > >> Code-level diagnostics for performance bottlenecks with <2% overhead > > >> Download for free and get started troubleshooting in minutes. > > >> http://p.sf.net/sfu/appdyn_d2d_ap1 > > >> _______________________________________________ > > >> enlightenment-devel mailing list > > >> enlightenment-devel@lists.sourceforge.net > > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >> > > > > > > > > > -- > > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > > > > > > ------------------------------------------------------------------------------ > > > Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET > > > Get 100% visibility into your production application - at no cost. > > > Code-level diagnostics for performance bottlenecks with <2% overhead > > > Download for free and get started troubleshooting in minutes. > > > http://p.sf.net/sfu/appdyn_d2d_ap1 > > > _______________________________________________ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > ------------------------------------------------------------------------------ > > Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET > > Get 100% visibility into your production application - at no cost. > > Code-level diagnostics for performance bottlenecks with <2% overhead > > Download for free and get started troubleshooting in minutes. > > http://p.sf.net/sfu/appdyn_d2d_ap1 > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > ------------------------------------------------------------------------------ > Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET > Get 100% visibility into your production application - at no cost. > Code-level diagnostics for performance bottlenecks with <2% overhead > Download for free and get started troubleshooting in minutes. > http://p.sf.net/sfu/appdyn_d2d_ap1 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Jérémy Zurcher av General Guisan 49 1400 Yverdon-les-bains +41 (0) 79 599 84 27 ------------------------------------------------------------------------------ Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET Get 100% visibility into your production application - at no cost. Code-level diagnostics for performance bottlenecks with <2% overhead Download for free and get started troubleshooting in minutes. http://p.sf.net/sfu/appdyn_d2d_ap1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
