I pushed this patch with the suggested changes, plese let me know if there is anything else needed to change.
Regards, Etrunko On Fri, Apr 19, 2013 at 11:05 AM, Eduardo Lima (Etrunko) <[email protected]> wrote: > On Fri, Apr 19, 2013 at 10:54 AM, Rafael Antognolli > <[email protected]> wrote: >> On Fri, Apr 19, 2013 at 6:56 AM, Chris Michael <[email protected]> >> wrote: >>> Also, you could use ecore_wl_registry_get instead of >>> wl_display_get_registry. >>> >>> And ecore_wl_display_iterate instead of wl_display_dispatch. >>> >>> dh >> >> Notice that the wl_display_dispatch (and consequently, >> ecore_wl_display_iterate) may also block the mainloop. BTW, are they >> really necessary here? > > I guess they are here for the sake of accessing the wl_registry and "globals". > >> >>> On 19/04/13 10:53, Chris Michael wrote: >>>> Hi Jan, >>>> >>>> Thanks for the efforts here :) >>>> >>>> After a quick review, this seems ok. Some of the formatting is wrong >>>> (ie: not EFL style), however that is just a minor thing. One thing that >>>> does concern me here tho is why: >>>> >>>> + wl_display_roundtrip(display); >>>> >>>> >>>> is being called in the im_module_init ? That does have the potential to >>>> completely block any further events from running on the ecore main loop >>>> until the wayland loop has finished, which could result in applications, >>>> modules, etc being delayed (or potentially never executing any more code >>>> if the wayland loop is still busy or never returns) >>>> >>>> dh >>>> >>>> >>>> On 19/04/13 09:27, Jan Arne Petersen wrote: >>>>> Hi, >>>>> >>>>> Add an input method module supporting the Wayland input method protocol >>>>> to ecore_imf. >>>>> >>>>> >>>>> >>> >>> >>> ------------------------------------------------------------------------------ >>> Precog is a next-generation analytics platform capable of advanced >>> analytics on semi-structured data. The platform includes APIs for building >>> apps and a phenomenal toolset for data science. Developers can use >>> our toolset for easy data analysis & visualization. Get a free account! >>> http://www2.precog.com/precogplatform/slashdotnewsletter >>> _______________________________________________ >>> enlightenment-devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> >> >> -- >> Rafael Antognolli >> http://antognolli.org/ >> >> ------------------------------------------------------------------------------ >> Precog is a next-generation analytics platform capable of advanced >> analytics on semi-structured data. The platform includes APIs for building >> apps and a phenomenal toolset for data science. Developers can use >> our toolset for easy data analysis & visualization. Get a free account! >> http://www2.precog.com/precogplatform/slashdotnewsletter >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > -- > Eduardo de Barros Lima ◤✠◢ > [email protected] -- Eduardo de Barros Lima ◤✠◢ [email protected] ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
