On Thu, 27 Jun 2013 09:12:14 +0900 Carsten Haitzler (The Rasterman) <ras...@rasterman.com> wrote:
> On Wed, 26 Jun 2013 08:56:43 -0700 Daniel Willmann - Enlightenment Git
> <no-re...@enlightenment.org> said:
>
> the ? operator is evil. pure evil.
I have no idea why it's being used here to choose between two boolean
values. Seems like overkill.
> > asdfuser pushed a commit to branch master.
> >
> > commit b088400a2bfa8422a83eeb4e08b1113e0a0b7fa2
> > Author: Daniel Willmann <d.willm...@samsung.com>
> > Date: Wed Jun 26 16:45:54 2013 +0100
> >
> > elc_naviframe.c: Correctly call _resize_object_reset()
> >
> > Incorrect use of the ?-operator...
> >
> > Signed-off-by: Daniel Willmann <d.willm...@samsung.com>
> > ---
> > src/lib/elc_naviframe.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/lib/elc_naviframe.c b/src/lib/elc_naviframe.c
> > index 328afc5..b3b8b5f 100644
> > --- a/src/lib/elc_naviframe.c
> > +++ b/src/lib/elc_naviframe.c
> > @@ -1493,7 +1493,7 @@ _item_push(Eo *obj, void *_pd, va_list *list)
> >
> > if (prev_it) elm_widget_focused_object_clear(VIEW(prev_it));
> > _resize_object_reset(obj, it, prev_it,
> > - (prev_it ? : EINA_FALSE, EINA_TRUE));
> > + (prev_it ? EINA_FALSE : EINA_TRUE));
> > if (prev_it)
> > {
> > if (sd->freeze_events)
> >
> > --
> >
> > ------------------------------------------------------------------------------
> > This SF.net email is sponsored by Windows:
> >
> > Build for Windows Store.
> >
> > http://p.sf.net/sfu/windows-dev2dev
> >
>
>
--
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
