Hello,

On Sat, Jul 13, 2013 at 3:43 AM, Rafael Antognolli <[email protected]> wrote:
> Ecore.h already includes Ecore_Eo.h, so why do we need this extra include?

Indeed. Well, I know exactly why. E*_Eo.h API is unstable and will not
be a supported feature for 1.8. This is why you need to use a specific
flag to turn it on. Example should not at this stage, I think, expose
any E*_Eo.h API as I don't think we want to encourage people to use
it.

I would be more for disabling the build of this example at this stage.

Regards,
  Cedric

> On Thu, Jul 11, 2013 at 5:44 AM, Stefan Schmidt - Enlightenment Git
> <[email protected]> wrote:
>> stefan pushed a commit to branch master.
>>
>> commit d10be60e30f19bc355a99018c6b07b265702f04a
>> Author: Stefan Schmidt <[email protected]>
>> Date:   Thu Jul 11 09:41:05 2013 +0100
>>
>>     examples: Add missing Ecore_Eo.h for some defines.
>>
>>     If we are shuffling headers around testing if in-tree examples are
>>     still working fine might be a sensible thing to do. Everybody agrees
>>     on that?
>> ---
>>  src/examples/ecore/ecore_idler_example.c  | 1 +
>>  src/examples/ecore/ecore_poller_example.c | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/src/examples/ecore/ecore_idler_example.c 
>> b/src/examples/ecore/ecore_idler_example.c
>> index de69a44..faef3a5 100644
>> --- a/src/examples/ecore/ecore_idler_example.c
>> +++ b/src/examples/ecore/ecore_idler_example.c
>> @@ -2,6 +2,7 @@
>>  // gcc -o ecore_idler_example ecore_idler_example.c `pkg-config --libs 
>> --cflags ecore eo`
>>
>>  #include <Ecore.h>
>> +#include <Ecore_Eo.h>
>>  #include <unistd.h>
>>
>>  struct context   // helper struct to give some context to the callbacks
>> diff --git a/src/examples/ecore/ecore_poller_example.c 
>> b/src/examples/ecore/ecore_poller_example.c
>> index ef8592b..1f76465 100644
>> --- a/src/examples/ecore/ecore_poller_example.c
>> +++ b/src/examples/ecore/ecore_poller_example.c
>> @@ -2,6 +2,7 @@
>>  // gcc -o ecore_poller_example ecore_poller_example.c `pkg-config --libs 
>> --cflags ecore eo`
>>
>>  #include <Ecore.h>
>> +#include <Ecore_Eo.h>
>>  #include <unistd.h>
>>
>>  static double _initial_time = 0;
>>
>> --
>>
>> ------------------------------------------------------------------------------
>> See everything from the browser to the database with AppDynamics
>> Get end-to-end visibility with application monitoring from AppDynamics
>> Isolate bottlenecks and diagnose root cause in seconds.
>> Start your free trial of AppDynamics Pro today!
>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
>
>
>
> --
> Rafael Antognolli
>
> ------------------------------------------------------------------------------
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>



--
Cedric BAIL

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to