On Thu, 18 Jul 2013 18:08:22 -0300 "Eduardo Lima (Etrunko)" <[email protected]> said:
> On Thu, Jul 18, 2013 at 5:19 AM, Carsten Haitzler - Enlightenment Git > <[email protected]> wrote: > > raster pushed a commit to branch master. > > > > commit d4faa01681ba0af17736c104ac972b4c3f3ecd6b > > Author: Carsten Haitzler (Rasterman) <[email protected]> > > Date: Thu Jul 18 17:19:13 2013 +0900 > > > > elm_player: now really dont self-event-feed on user drag + chg slider. > > --- > > src/lib/elc_player.c | 54 +++++++++++++++++++++++ > > +--------------------- src/lib/elm_widget_player.h | 3 +-- > > 2 files changed, 30 insertions(+), 27 deletions(-) > > > > diff --git a/src/lib/elc_player.c b/src/lib/elc_player.c > > index 52e5a6e..5745761 100644 > > --- a/src/lib/elc_player.c > > +++ b/src/lib/elc_player.c > > @@ -25,6 +25,18 @@ static const char SIG_PLAY_CLICKED[] = "play,clicked"; > > static const char SIG_PREV_CLICKED[] = "prev,clicked"; > > static const char SIG_REWIND_CLICKED[] = "rewind,clicked"; > > static const char SIG_STOP_CLICKED[] = "stop,clicked"; > > +/* XXX: other things player SHOULD support > > +static const char SIG_STOP_CLICKED[] = "repeat,clicked"; > > +static const char SIG_STOP_CLICKED[] = "shuffle,clicked"; > > +static const char SIG_STOP_CLICKED[] = "eject,clicked"; > > +static const char SIG_STOP_CLICKED[] = "record,clicked"; > > +static const char SIG_STOP_CLICKED[] = "eject,clicked"; > > +static const char SIG_STOP_CLICKED[] = "replay,clicked"; > > +static const char SIG_STOP_CLICKED[] = "power,clicked"; > > +static const char SIG_STOP_CLICKED[] = "volume,clicked"; > > +static const char SIG_STOP_CLICKED[] = "eject,clicked"; > > +static const char SIG_STOP_CLICKED[] = "mute,clicked"; > > + */ > > > > Shouldn't you rename those variables accordingly? the day they are implemented... yes. notice the comments... it's just "notes" for stuff this widget SHOULD at some point do... > -- > Eduardo de Barros Lima ◤✠◢ > [email protected] > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
