On Fri, Jul 19, 2013 at 11:31 AM, Cedric BAIL <[email protected]> wrote:
> On Fri, Jul 19, 2013 at 3:12 PM, José Roberto de Souza - Enlightenment > Git <[email protected]> wrote: > > zehortigoza pushed a commit to branch master. > > > > commit 4732679935de40babf02bfe9473e21a23662f276 > > Author: José Roberto de Souza <[email protected]> > > Date: Fri Jul 19 10:09:09 2013 -0300 > > > > edje: Add missing ChangeLog and NEWS of signal callbacks fixes > > Not necessary, the bug was introduced during the 1.8 release cycle and > btw thanks for the fix ! Really good catch ! > SPANK CEDRIC... it took us days to figure it out... just because mister cedric-the-crazy-french decided it was worth to save 4bits BITS -- yes 4 BITS, given that for these "wasted" 4 bits we use real memory for 3 pointers (3 * sizeof(void*) == 12(32bits) or 24(64bits))... with a really bad code readability :-( I've asked José to rewrite that code so flags is actually struct { unsigned char delete_me:1, propagate:1, just_added:1}... while we "loose 4 bits" (OMG, world collapses!) we gain readability again :-D -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
