On 08/08/13 12:03, Mike McCormack wrote:
> On 08/08/2013 07:27 PM, Christopher Michael wrote:
>> I believe that I have discovered a problem with the glib integration
>> into ecore main loop. Basically the issue is this:
>>
>> _ecore_main_fdh_poll_add is calling g_source_add_poll (which seems correct)
>>
>> BUT
>>
>> _ecore_main_fdh_poll_del is callback g_source_add_poll also (which
>> smells wrong).
>>
>> Shouldn't that be doing g_source_remove_poll ??
>
> Yeah, it looks wrong to me too.  Looks like a copy and paste error
> introduced some time ago.
>
Indeed :)

Are you ok if I fix this (use g_source_remove_poll there). Or are you 
already planning to fix this ??

> Are you guys going to use the g_main_loop integration for something
> serious, or did you just spot a bug?
>
> thanks,
>
> Mike

Just something I spotted randomly while researching something else ;)

Cheers,
dh



------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to