On 09/30/2013 02:10 PM, Daniel Juyung Seo wrote: > Thanks Mariusz Bialonczyk for your patch. > As Stefan mentioned it's not a typo fix. Thanks Stefan for the fix. > > Btw Mariusz, can you raise a patch with phabricator + arcanist next time? > https://phab.enlightenment.org/w/arcanist/
It was me who told him to use git format-patch and send it via mail. > It's easy and quick to submit a patch than writing an email. You really think that? Given you have to install php, a new tool and learn it also. And also given you just mailed to the list with a problem using it :) I also think its quite unlikely that people would jump through all the hops for one patch. If they plan on more and trying to become a real commiter that might be worth the time but for only one patch I daubt it. > You can get a review and feedback as well from the system line by line > easily. That is indeed a nice thing. But I have to say I find the whole workflow quite arkward. But maybe it only me being used to patches and review on the ml. regards Stefan Schmidt ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel