It's impossible! This man has a second life during the night and he can't be late. Gangnam can't live without him.
On 10/01/2013 12:52 PM, Michael Blumenkrantz wrote: > commit now! test/review later! > > > On Tue, Oct 1, 2013 at 10:48 AM, Jean-Philippe André <j...@videolan.org>wrote: > >> Hi! >> >> Indeed, I totally missed that case as all elementary_test cases call show() >> after file_set()... >> The commit to blame was dcb8b54aee3a545a1. >> >> So, let me explain why I introduced these changes in the first place. >> While working on cserve2 (I'll talk about it more soon!), I realized that >> even "huge" images were fully (pre)loaded automatically, even if they are >> not used and proper load_opts are set afterwards (to load only a smaller >> image out of a jpeg file). >> So I wanted to avoid excessive preloading (cpu and memory usage). >> >> But if the object is visible, elm_image expects (pre)loading at some point. >> >> Please find the attached patch. I'll submit tomorrow morning if there are >> no complains (unless someone submits for me by then :) ) >> >> All my tests (elementary_test and ev) work now. Ping me if you still have >> issues! >> >> Sorry again about that. >> JP >> >> PS: yeah, I couldn't use Arcanist today... >> >> >> >> 2013/10/1 daniel.za...@samsung.com <daniel.za...@samsung.com> >> >>> Yo JP, >>> >>> Could your commit be the cause of the non loading of the image if >>> file_set is done after show? >>> Now, only if show is done after file_set, it will load it. >>> >>> JackDanielZ, alias Daniel >>> >>> >>> On 09/26/2013 01:00 PM, Jean-Philippe Andre wrote: >>>> jpeg pushed a commit to branch master. >>>> >>>> >> http://git.enlightenment.org/core/elementary.git/commit/?id=a5c851ff1e1e5c3182600503fed41eaa7161eb35 >>>> commit a5c851ff1e1e5c3182600503fed41eaa7161eb35 >>>> Author: Jean-Philippe Andre <jp.an...@samsung.com> >>>> Date: Thu Sep 26 18:55:44 2013 +0900 >>>> >>>> elm_image: Fix remote image loading >>>> >>>> Fixes commit dcb8b54aee3a545a1: >>>> - elm_image: do not preload full image on file_set. >>>> >>>> elementary_test "Image Remote" was not working anymore because >>>> the image was never loaded after download. >>>> --- >>>> src/lib/elm_image.c | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/src/lib/elm_image.c b/src/lib/elm_image.c >>>> index acf4b89..5e19225 100644 >>>> --- a/src/lib/elm_image.c >>>> +++ b/src/lib/elm_image.c >>>> @@ -889,6 +889,12 @@ _elm_image_smart_download_done(void *data, Elm_Url >>> *url EINA_UNUSED, Eina_Binbuf >>>> } >>>> else >>>> { >>>> + if (evas_object_visible_get(obj)) >>>> + { >>>> + Evas_Object *eobj = elm_image_object_get(obj); >>>> + evas_object_image_preload(eobj, EINA_FALSE); >>>> + } >>>> + >>>> evas_object_smart_callback_call(obj, SIG_DOWNLOAD_DONE, >> NULL); >>>> } >>>> >>>> >>> >>> >>> >> ------------------------------------------------------------------------------ >>> October Webinars: Code for Performance >>> Free Intel webinars can help you accelerate application performance. >>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most >>> from >>> the latest Intel processors and coprocessors. See abstracts and register >>> >>> >> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk >>> _______________________________________________ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>> >>> >> >> -- >> Jean-Philippe André >> >> >> ------------------------------------------------------------------------------ >> October Webinars: Code for Performance >> Free Intel webinars can help you accelerate application performance. >> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most >> from >> the latest Intel processors and coprocessors. See abstracts and register > >> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
