Hey Ryuan (and everyone), This commit does not fix a warning. I mean it might fix a warning, but that's not the most important thing about this commit. The most important things about this commit are: 1. Fix the correct return value. 2. Fix call to the super function.
Both are essential and super important (making this fix awesome), while fixing a warning sounds simple. While the commit message itself is good, the summary line is not, and the summary line is the most important line for people skimming/reviewing commits. -- Tom. On 11/10/13 14:08, Ryuan Choi wrote: > ryuan pushed a commit to branch master. > > http://git.enlightenment.org/core/elementary.git/commit/?id=d16468d6afef1ba05098b1d6e21637d465dd50eb > > commit d16468d6afef1ba05098b1d6e21637d465dd50eb > Author: Ryuan Choi <ryuan.c...@gmail.com> > Date: Fri Oct 11 21:52:15 2013 +0900 > > elm_win: Fixed warning after 99ab56d5 > > ELM_WIDGET_SUB_ID_THEME needs to return Eina_Bool. > In addition, calls the super function of ELM_WIDGET_SUB_ID_THEME. > > Reproduce step is changing profile in elementary_config. > --- > src/lib/elm_win.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/src/lib/elm_win.c b/src/lib/elm_win.c > index f7a5ffe..fcff212 100644 > --- a/src/lib/elm_win.c > +++ b/src/lib/elm_win.c > @@ -5211,8 +5211,18 @@ static void > _elm_win_smart_theme(Eo *obj EINA_UNUSED, void *_pd, va_list *list > EINA_UNUSED) > { > Elm_Win_Smart_Data *sd = _pd; > + Eina_Bool *ret = va_arg(*list, Eina_Bool *); > + Eina_Bool int_ret = EINA_FALSE; > + > + if (ret) *ret = EINA_TRUE; > + > + eo_do_super(obj, MY_CLASS, elm_wdg_theme(&int_ret)); > + if (!int_ret) return; > + > sd->focus_highlight.theme_changed = EINA_TRUE; > _elm_win_focus_highlight_reconfigure_job_start(sd); > + > + if (ret) *ret = EINA_TRUE; > } > > static void > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
