On Fri, 11 Oct 2013 16:12:39 +0100 Tom Hacohen <tom.haco...@samsung.com> wrote:
> On 11/10/13 16:00, Michael Blumenkrantz wrote: > > On Fri, 11 Oct 2013 11:56:59 -0300 > > Gustavo Lima Chaves <gl...@profusion.mobi> wrote: > > > >> * Gustavo Sverzut Barbieri <barbi...@gmail.com> [2013-10-11 11:41:46 > >> -0300]: > >> > >>> On Thu, Oct 10, 2013 at 11:28 PM, Cedric Bail <cedric.b...@samsung.com> > >>> wrote: > >>>> cedric pushed a commit to branch master. > >>>> > >>>> http://git.enlightenment.org/core/efl.git/commit/?id=7caef271dc7d52b119d3ca607ec8721fc2660b5e > >>>> > >>>> commit 7caef271dc7d52b119d3ca607ec8721fc2660b5e > >>>> Author: Cedric Bail <cedric.b...@samsung.com> > >>>> Date: Thu Oct 10 18:02:00 2013 +0900 > >>>> > >>>> ecore: Use Eina_Spinlock for Ecore_Thread. > >>>> --- > >>>> ChangeLog | 1 + > >>>> NEWS | 2 + > >>>> src/lib/ecore/ecore_thread.c | 156 > >>>> ++++++++++++++++++++++--------------------- > >>>> 3 files changed, 84 insertions(+), 75 deletions(-) > >>>> > >>>> diff --git a/ChangeLog b/ChangeLog > >>>> index 4109be5..58d181b 100644 > >>>> --- a/ChangeLog > >>>> +++ b/ChangeLog > >>>> @@ -5,6 +5,7 @@ > >>>> Eina_Chained_Mempool. > >>>> * Eet: replace Eina_Lock by Eina_Spinlock in Eet_Dictionnary. > >>>> * Evas: replace Eina_Lock by Eina_Spinlock in Evas_ScaleCache, > >>>> Evas_Async_Events and Image_Entry. > >> > >> And more importantly, can you PLEASE commit you API additions already > >> documented? It's fucking annoying (sorry, no other term fits better > >> here) to have all this legacy behavior of never (or > >> barely/badly/scarcely) documented functions. > >> > >>> > >>> this is internal, why does it matter to say we changed an internal > >>> implementation? > > > > imo it would be good to adopt a policy where any new api that's added > > without documentation gets reverted immediately until the documentation is > > added. it's 2013, we've done releases before, this behavior is totally > > unacceptable. > > Yes, unit tests as well. Our code coverage should increase over time, > not decrease. > > -- > Tom. > I assume you mean the coverage percentage, and I agree. ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
