On Fri, Oct 11, 2013 at 10:20 PM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Fri, 11 Oct 2013 11:53:40 -0300 Gustavo Sverzut Barbieri > <barbi...@gmail.com> said: > >> On Fri, Oct 11, 2013 at 4:50 AM, Carsten Haitzler <ras...@rasterman.com> >> wrote: >> > raster pushed a commit to branch master. >> > >> > http://git.enlightenment.org/core/efl.git/commit/?id=69e27abdc37f222183ce27f4ce0e3fe2a45ca590 >> > >> > commit 69e27abdc37f222183ce27f4ce0e3fe2a45ca590 >> > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com> >> > Date: Fri Oct 11 16:49:13 2013 +0900 >> > >> > eina - and e3fl in general - stop using eina_error_get/set - useless >> > really >> >> while it's not the best thing to use and many places forget to set the >> error, knowing which error happened may be useful -- in the same >> lines when you get an EINTR/EAGAIN from syscalls. By just not getting >> the results we want we fail to provide context on why it failed :-( > > i know. problem is that our current usage is broken anyway. i\eina has lots of > locks etc. to be threadsafe... but the eina_error system simply isn't and > pretty > much cannot be, so it's already broken when you use eina from > 1 thread. so i > just made it "always not working". at least it's consistently broken. :)
Ugh? Just make it a thread-local value, as errno. -- Gustavo Sverzut Barbieri -------------------------------------- Mobile: +55 (19) 9225-2202 Contact: http://www.gustavobarbieri.com.br/contact ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
