seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=825d357baa20f3c36b5f4c51b42bd507ca21ba5a

commit 825d357baa20f3c36b5f4c51b42bd507ca21ba5a
Author: Daniel Juyung Seo <seojuyu...@gmail.com>
Date:   Thu Nov 7 00:00:38 2013 +0900

    test_progressbar.c: Fixed wrong null set of timer.
    
    If pd is null, pd->timer will crash and cannot set it to null.
    This fixes coverity CID 1126081.
---
 src/bin/test_progressbar.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/bin/test_progressbar.c b/src/bin/test_progressbar.c
index d5256d7..997a9f4 100644
--- a/src/bin/test_progressbar.c
+++ b/src/bin/test_progressbar.c
@@ -259,11 +259,7 @@ _progressbar2_timer_cb(void *data)
    Progressbar_Data *pd = data;
    double progress;
 
-   if (!pd)
-     {
-        pd->timer = NULL;
-        return ECORE_CALLBACK_CANCEL;
-     }
+   if (!pd) return ECORE_CALLBACK_CANCEL;
 
    progress = elm_progressbar_value_get (pd->pb1);
 

-- 


Reply via email to