On Mon, Nov 4, 2013 at 6:58 PM, ChunEon Park <her...@naver.com> wrote:
> here state off totally depends on the ECORE_X_VIRTUAL_KEYBOARD_STATE_ON/OFF > and state on/off is closed to the visibility of the keyboard. > invisble means not 0 sized. > > Actual keyboard size should be changed when ILLUME_ZONE and > ILLUME_GEOMETRY both are changed. > > So I said it's logically wrong. > only ILLUME_ZONE and ILLUME_GEOMETRY are changed then it should be called. > You're logically right but ut still size is changed. We CANNOT call "size,changed" callback even the size is changed? Hmm... > > But REAL problem is, we don't need to provide that kind of function rather > than user need to catch up the changes of their content. > since the content size will be not only chagned by keyboard but other > parts such clipboard, indicator, softkey ... > > The comment is now reasonable but I already answered this to raster's email. Thanks. Daniel Juyung Seo (SeoZ) > ------------------------------------ > -Regards, Hermet- > > -----Original Message----- > From: "Daniel Juyung Seo"<seojuyu...@gmail.com> > To: "Enlightenment developer list"< > enlightenment-devel@lists.sourceforge.net>; > Cc: <g...@lists.enlightenment.org>; > Sent: 2013-11-04 (월) 18:16:12 > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: > elm_conform.c: Added "virtualkeypad, size, changed" smart callback. > > On Mon, Nov 4, 2013 at 5:08 PM, ChunEon Park <hermet>@naver.com> wrote: > > > incorrect. > > > > state is not regarded to the size. > > State defines just on/off. it does not mean "size changed". > > > > Oh that's intersting. Do you use zero sized virtual keypad? LOL > Please share a video. > Thanks. > > Daniel Juyung Seo (SeoZ) > > > > > > if you think size, changed covers the state on/off > > then the name should be state,changed. > > > > the scope of the size change is under the state change. > > but state change does not under the size change scope. > > > > > > ------------------------------------ > > -Regards, Hermet- > > > > -----Original Message----- > > From: "Daniel Juyung Seo"<seojuyung2>@gmail.com> > > To: "Enlightenment developer list"< > > enlightenment-devel@lists.sourceforge.net>; > > Cc: <git>@lists.enlightenment.org>; > > Sent: 2013-11-04 (월) 16:34:51 > > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: > > elm_conform.c: Added "virtualkeypad, size, changed" smart callback. > > > > On Thu, Oct 31, 2013 at 6:03 PM, ChunEon Park <hermet>@naver.com> wrote: > > > > > Sorry. I don't agree on this change. > > > > > > This callback will be called wheneven any keypad state is changed. > > > regardless of the size changed. > > > > > > > If you meant *keypad state change* by "virtualkeypad,state,on/off", > keypad > > size is changed as well. > > So it's correct. > > The new callback covers more use cases than just > > "virtualkeypad,state,on/off". > > Application code can be rewritten simpler by the new api than previous > one. > > > > If there is any cases that "virtualkeypad,size,changed" is called even > > though keypad size is not changed, please let me know. > > Thanks in advance. > > > > Daniel Juyung Seo (SeoZ) > > > > > > > > > > > > > > > ------------------------------------ > > > -Regards, Hermet- > > > > > > -----Original Message----- > > > From: "Daniel Juyung Seo"<seojuyung2>@gmail.com> > > > To: <git>@lists.enlightenment.org>; > > > Cc: > > > Sent: 2013-10-30 (수) 16:24:37 > > > Subject: [EGIT] [core/elementary] master 01/01: elm_conform.c: Added > > > "virtualkeypad,size,changed" smart callback. > > > > > > seoz pushed a commit to branch master. > > > > > > > > > > > > http://git.enlightenment.org/core/elementary.git/commit/?id=cbd7446f0bf413ad821ac40703d2a2ca728758ef > > > > > > commit cbd7446f0bf413ad821ac40703d2a2ca728758ef > > > Author: Daniel Juyung Seo <seojuyung2>@gmail.com> > > > Date: Wed Oct 30 16:17:57 2013 +0900 > > > > > > elm_conform.c: Added "virtualkeypad,size,changed" smart callback. > > > > > > When the virtualkeypad size is changed, applications get the > notice. > > > Applications can do internal object calculation according to the > > exact > > > virtualkeypad size. > > > This is useful when the exact size is important such as webkit > > usecase. > > > --- > > > ChangeLog 4 ++++ > > > NEWS 1 + > > > src/lib/elm_conform.c 7 +++++++ > > > src/lib/elm_conform.h 3 +++ > > > 4 files changed, 15 insertions(+) > > > > > > diff --git a/ChangeLog b/ChangeLog > > > index fbeecc7..e99d3fd 100644 > > > --- a/ChangeLog > > > +++ b/ChangeLog > > > @@ -1727,3 +1727,7 @@ > > > 2013-10-30 Amitesh Singh (_ami_) > > > > > > * image: Add support for "clicked" callback on > > > Return/space/KP_Enter key press. > > > + > > > +2013-10-30 Daniel Juyung Seo (SeoZ) > > > + > > > + * conform: Added "virtualkeypad,size,changed" callback on > > > virtualkeypad min size change. > > > diff --git a/NEWS b/NEWS > > > index 8481107..6876073 100644 > > > --- a/NEWS > > > +++ b/NEWS > > > @@ -101,6 +101,7 @@ Additions: > > > * Add elm_fileselector_hidden_visible_set/get() to show or hide > > hidden > > > files/directories. > > > * Add signals "spinner,drag,start" and "spinner,drag,stop" to the > > > spinner widget. > > > * Add support for "clicked" callback on Return/space/KP_Enter key > > > press for image. > > > + * Add "virtualkeypad,size,changed" callback on virtualkeypad min > size > > > change for conformant. > > > > > > Improvements: > > > > > > diff --git a/src/lib/elm_conform.c b/src/lib/elm_conform.c > > > index 9636ab8..cb00888 100644 > > > --- a/src/lib/elm_conform.c > > > +++ b/src/lib/elm_conform.c > > > @@ -36,12 +36,14 @@ static const char SOFTKEY_PART[] = > > > "elm.swallow.softkey"; > > > > > > static const char SIG_VIRTUALKEYPAD_STATE_ON[] = > > "virtualkeypad,state,on"; > > > static const char SIG_VIRTUALKEYPAD_STATE_OFF[] = > > > "virtualkeypad,state,off"; > > > +static const char SIG_VIRTUALKEYPAD_SIZE_CHANGED[] = > > > "virtualkeypad,size,changed"; > > > static const char SIG_CLIPBOARD_STATE_ON[] = "clipboard,state,on"; > > > static const char SIG_CLIPBOARD_STATE_OFF[] = "clipboard,state,off"; > > > > > > static const Evas_Smart_Cb_Description _smart_callbacks[] = { > > > {SIG_VIRTUALKEYPAD_STATE_ON, ""}, > > > {SIG_VIRTUALKEYPAD_STATE_OFF, ""}, > > > + {SIG_VIRTUALKEYPAD_SIZE_CHANGED, ""}, > > > {SIG_CLIPBOARD_STATE_ON, ""}, > > > {SIG_CLIPBOARD_STATE_OFF, ""}, > > > {NULL, NULL} > > > @@ -166,6 +168,8 @@ _conformant_part_sizing_eval(Evas_Object *obj, > > > > > > if (part_type & ELM_CONFORMANT_VIRTUAL_KEYPAD_PART) > > > { > > > + Evas_Coord_Rectangle rect; > > > + > > > #ifdef HAVE_ELEMENTARY_X > > > if ((!_conformant_part_geometry_get_from_env > > > ("ILLUME_KBD", &sx, &sy, &sw, &sh)) && (xwin)) > > > @@ -189,6 +193,9 @@ _conformant_part_sizing_eval(Evas_Object *obj, > > > DBG("[KEYPAD]: size(%d,%d, %dx%d).", sx, sy, sw, sh); > > > _conformant_part_size_hints_set > > > (obj, sd->virtualkeypad, sx, sy, sw, sh); > > > + > > > + rect.x = sx; rect.y = sy; rect.w = sw; rect.h = sh; > > > + evas_object_smart_callback_call(obj, > > > SIG_VIRTUALKEYPAD_SIZE_CHANGED, (void *)&rect); > > > } > > > > > > if (part_type & ELM_CONFORMANT_SOFTKEY_PART) > > > diff --git a/src/lib/elm_conform.h b/src/lib/elm_conform.h > > > index a491b95..e1187b5 100644 > > > --- a/src/lib/elm_conform.h > > > +++ b/src/lib/elm_conform.h > > > @@ -28,6 +28,9 @@ > > > * (@since 1.8) > > > * @li "virtualkeypad,state,off": if virtualkeypad state is switched > to > > > "off". > > > * (@since 1.8) > > > + * @li "virtualkeypad,size,changed": this is called when virtualkeypad > > > size is > > > + * changed. @c event_info parameter is the virtualkeypad size in > > > + * Evas_Coord_Rectangle structure. (@since 1.8) > > > * @li "clipboard,state,on": if clipboard state is switched to "on". > > > * (@since 1.8) > > > * @li "clipboard,state,off": if clipboard state is switched to "off". > > > > > > -- > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > Android is increasing in popularity, but the open development platform > > that > > > developers love is also attractive to malware creators. Download this > > white > > > paper to learn more about secure code signing practices that can help > > keep > > > Android apps secure. > > > > > > http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk > > > _______________________________________________ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > ------------------------------------------------------------------------------ > > Android is increasing in popularity, but the open development platform > that > > developers love is also attractive to malware creators. Download this > white > > paper to learn more about secure code signing practices that can help > keep > > Android apps secure. > > > http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > ------------------------------------------------------------------------------ > > Android is increasing in popularity, but the open development platform > that > > developers love is also attractive to malware creators. Download this > white > > paper to learn more about secure code signing practices that can help > keep > > Android apps secure. > > > http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > ------------------------------------------------------------------------------ > Android is increasing in popularity, but the open development platform that > developers love is also attractive to malware creators. Download this white > paper to learn more about secure code signing practices that can help keep > Android apps secure. > http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ > Android is increasing in popularity, but the open development platform that > developers love is also attractive to malware creators. Download this white > paper to learn more about secure code signing practices that can help keep > Android apps secure. > http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
