seoz pushed a commit to branch master.

http://git.enlightenment.org/apps/terminology.git/commit/?id=20afe23c5bded93fe0b18e5ccf417df2931f3f1f

commit 20afe23c5bded93fe0b18e5ccf417df2931f3f1f
Author: Daniel Juyung Seo <seojuyu...@gmail.com>
Date:   Fri Nov 8 08:32:47 2013 +0900

    termio: fixed null pointer dereferencing issue.
    
    This fixes coverity CID 1100645.
---
 src/bin/termio.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/bin/termio.c b/src/bin/termio.c
index 5286bc0..f6c399d 100644
--- a/src/bin/termio.c
+++ b/src/bin/termio.c
@@ -1824,10 +1824,13 @@ _take_selection(Evas_Object *obj, Elm_Sel_Type type)
              char *tmp = termio_selection_get(obj, start_x, i, end_x, i,
                                               &len);
 
-             eina_strbuf_append_length(sb, tmp, len);
-             if (len && tmp[len - 1] != '\n')
-               eina_strbuf_append_char(sb, '\n');
-             free(tmp);
+             if (tmp)
+               {
+                  eina_strbuf_append_length(sb, tmp, len);
+                  if (len && tmp[len - 1] != '\n')
+                    eina_strbuf_append_char(sb, '\n');
+                  free(tmp);
+               }
           }
         len = eina_strbuf_length_get(sb);
         s = eina_strbuf_string_steal(sb);

-- 


Reply via email to