seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=6aa7eac77f2980a80055a193de367bf007b28e16

commit 6aa7eac77f2980a80055a193de367bf007b28e16
Author: Daniel Juyung Seo <seojuyu...@gmail.com>
Date:   Fri Nov 8 11:22:01 2013 +0900

    elm_prefs_data.c: Check return value of eina_value_get().
    
    This fixes coverity CID 1040042.
---
 src/lib/elm_prefs_data.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/lib/elm_prefs_data.c b/src/lib/elm_prefs_data.c
index 9a61230..3d192c3 100644
--- a/src/lib/elm_prefs_data.c
+++ b/src/lib/elm_prefs_data.c
@@ -444,8 +444,10 @@ _eet_data_save(const Elm_Prefs_Data *prefs_data,
         if (it->type == ELM_PREFS_TYPE_PAGE)
           {
              const char *n;
-             eina_value_get(&item->value, &n);
-             _eet_data_save(prefs_data, eet_file, n);
+             if (eina_value_get(&item->value, &n))
+               _eet_data_save(prefs_data, eet_file, n);
+             else
+               err = EINA_TRUE;
           }
 
         const Eina_Value_Type *t = eina_value_type_get(&(item->value));

-- 


Reply via email to