On Tue, 19 Nov 2013 09:59:07 +0100 Stefan Schmidt <ste...@datenfreihafen.org> said:
> Hello. > > On Tue, 2013-11-19 at 08:08, Carsten Haitzler wrote: > > On Mon, 18 Nov 2013 16:03:45 +0100 Stefan Schmidt > > <ste...@datenfreihafen.org> said: > > > > > Hello. > > > > > > On Sat, 2013-11-16 at 18:11, Carsten Haitzler wrote: > > > > raster pushed a commit to branch master. > > > > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=80d666e7a461c8c76adb01788dc746146bf8ab35 > > > > > > > > commit 80d666e7a461c8c76adb01788dc746146bf8ab35 > > > > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com> > > > > Date: Sun Nov 17 11:03:20 2013 +0900 > > > > > > > > ecore-audio - protect against more list-walking while list is > > > > modified > > > > > > And the e-b0rker trophy for this weekened goes to ... (short pause to > > > get full attention of the audience) > > > > > > raster himself!!!!! > > > > > > (Tears and hugs all over the stage) > > > > > > You tried to cover this with the crippled echo on bsd fix you reviewed > > > and put it which broke make distcheck on. After fixing this I had to > > > learn that this broke ecore tests in make distcheck. Not in make check > > > though. Seems like Cedrics job in Korea is indeed done. > > > > the echo fix worked. make doc worked at any rate. i did comment that the > > double \\ was odd in the approval comments. > > Indeed make doc also works without my fix. Funny and very odd if you > ask me. That explains why you haven't seen it. You did run a make doc > but not a make distcheck. > > With my fixup both are working. Maybe someone with a deep > understanding of escape sequences in automake can explain why make doc > still works. To me that makes no sense at all. But its fixed now for > all cases which is all I care about right now. :) > > > > More seriously I have no idea why it breaks but reverting this one > > > commit makes it worki again. After fixing the other one I'm to lazy to > > > fix this now. Lucky for you I'm also to lazy to revert. Or I'm in hope > > > someone will have a look soon. :) > > > > i cannot see why this breaks something. it does fix things when you DONT > > have pulseaudio working... and you need to make sounds. ie there are > > multiple audio ev out fails waiting to be called and the callbacks are > > deleting the out objects AS the list is being walked. this forces all of > > the objects int he list to first add a refcount to ensure they stay - then > > walk, then walk through and unref them safely (if the current obj unref > > gets it to 0 - it may be removed from the list, but we use the safe foreach > > so we're good). > > > > so there's an extra ref of all list items then unref of list items arfter > > all is said and done to fix the issue at hand. so removing this would cause > > segs for ppl without pulse when audio is used. > > I don't argue to remove your patch. I argue that it fails the tests on > my system in some cases. It could be that the tests are broken or my > system. In any case it is this commit that breaks it for me. maybe the tests are wrong? u need a running pulse... ? > Jenkins on the other hand seems happy though and as long as nobody > else has problems with it I might put it away as some oddity of my > system. Until it pops up again. :) > > regards > Stefan Schmidt > > ------------------------------------------------------------------------------ > Shape the Mobile Experience: Free Subscription > Software experts and developers: Be at the forefront of tech innovation. > Intel(R) Software Adrenaline delivers strategic insight and game-changing > conversations that shape the rapidly evolving mobile landscape. Sign up now. > http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
