On Wed, 20 Nov 2013 10:10:07 +0000 Tom Hacohen <tom.haco...@samsung.com> said:
> You stole credit. :) > > Either don't change people's commits (and just add a fixup commit) or > make sure to manually set the author to the correct value... i didnt steal credit - i used arc toi patch it in it SHOULD have kept author. it has in the past. the tool went wrong somehow - i don't know why/how. arch patch etc. set the author FROM the phab/arc patch info. or have in the past. > -- > Tom. > > On 19/11/13 23:42, Carsten Haitzler (Rasterman) wrote: > > raster pushed a commit to branch master. > > > > http://git.enlightenment.org/core/efl.git/commit/?id=0146e3dacc87189eba100bf5489498290ec9f86b > > > > commit 0146e3dacc87189eba100bf5489498290ec9f86b > > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com> > > Date: Wed Nov 20 08:41:42 2013 +0900 > > > > Docs fix for ecore_animator_add fixed > > > > Summary: > > Function returns boolean value, docs said it can return int. > > I had fixed that. > > > > Reviewers: cedric, raster > > > > Reviewed By: raster > > > > CC: cedric > > > > Differential Revision: https://phab.enlightenment.org/D342 > > --- > > src/lib/ecore/Ecore_Legacy.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/src/lib/ecore/Ecore_Legacy.h b/src/lib/ecore/Ecore_Legacy.h > > index 0bc0009..d7d01ce 100644 > > --- a/src/lib/ecore/Ecore_Legacy.h > > +++ b/src/lib/ecore/Ecore_Legacy.h > > @@ -86,9 +86,9 @@ EAPI void *ecore_poller_del(Ecore_Poller *poller); > > * the @p frametime interval set by ecore_animator_frametime_set(). The > > * function will be passed the @p data pointer as its parameter. > > * > > - * When the animator @p func is called, it must return a value of either 1 > > or > > - * 0. If it returns 1 (or ECORE_CALLBACK_RENEW), it will be called again at > > - * the next tick, or if it returns 0 (or ECORE_CALLBACK_CANCEL) it will be > > + * When the animator @p func is called, it must return a boolean value. > > + * If it returns EINA_TRUE (or ECORE_CALLBACK_RENEW), it will be called > > again at > > + * the next tick, or if it returns EINA_FALSE (or ECORE_CALLBACK_CANCEL) > > it will be > > * deleted automatically making any references/handles for it invalid. > > * > > * @note The default @p frametime value is 1/30th of a second. > > > > > ------------------------------------------------------------------------------ > Shape the Mobile Experience: Free Subscription > Software experts and developers: Be at the forefront of tech innovation. > Intel(R) Software Adrenaline delivers strategic insight and game-changing > conversations that shape the rapidly evolving mobile landscape. Sign up now. > http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
