raster pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=abb06c111b9467beb6f1d3e360dbc3fbb6e6e0f9
commit abb06c111b9467beb6f1d3e360dbc3fbb6e6e0f9
Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
Date: Fri Dec 6 09:07:44 2013 +0900
evas - silence coverty (false positive leak)
the hash can't leak where coverty thinks... because the hash find can
never work ... because the hash is empty.
---
src/lib/evas/canvas/evas_clip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lib/evas/canvas/evas_clip.c b/src/lib/evas/canvas/evas_clip.c
index a3f7480..4472fd5 100644
--- a/src/lib/evas/canvas/evas_clip.c
+++ b/src/lib/evas/canvas/evas_clip.c
@@ -83,7 +83,7 @@ evas_object_child_map_across_mark(Evas_Object *eo_obj,
Evas_Object_Protected_Dat
visited = eina_hash_pointer_new(NULL);
clear_visited = EINA_TRUE;
}
- if (eina_hash_find(visited, &eo_obj) == (void *)1) return;
+ if (eina_hash_find(visited, &eo_obj) == (void *)1) goto end;
else eina_hash_direct_add(visited, &eo_obj, (void *)1);
if ((obj->map->cur.map_parent != map_obj) || force)
@@ -124,6 +124,7 @@ evas_object_child_map_across_mark(Evas_Object *eo_obj,
Evas_Object_Protected_Dat
}
}
}
+end:
if (clear_visited) eina_hash_free(visited);
#endif
}
--
