englebass pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=2b9710431e55064c662d44a92660fcc307497ebf

commit 2b9710431e55064c662d44a92660fcc307497ebf
Author: Sebastian Dransfeld <s...@tango.flipp.net>
Date:   Sat Dec 7 15:34:55 2013 +0100

    eldbus: use alloca to allocate local mem
    
    Since we free the allocated mem some lines down, we can use alloca. This
    also fixes CID 1039179
---
 src/lib/eldbus/eldbus_message_from_eina_value.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/lib/eldbus/eldbus_message_from_eina_value.c 
b/src/lib/eldbus/eldbus_message_from_eina_value.c
index f94ca42..590d830 100644
--- a/src/lib/eldbus/eldbus_message_from_eina_value.c
+++ b/src/lib/eldbus/eldbus_message_from_eina_value.c
@@ -324,7 +324,7 @@ _message_iter_from_eina_value_struct(const char *signature, 
Eldbus_Message_Iter
              Eldbus_Message_Iter *sub_iter;
              char *sub_sig;
              unsigned len = strlen(type+1) -1;
-             sub_sig = malloc(sizeof(char) * len);
+             sub_sig = alloca(sizeof(char) * len);
              memcpy(sub_sig, type+1, len);
              sub_sig[len-1] = 0;
              EINA_SAFETY_ON_FALSE_RETURN_VAL(
@@ -335,7 +335,6 @@ _message_iter_from_eina_value_struct(const char *signature, 
Eldbus_Message_Iter
              r = _message_iter_from_eina_value_struct(sub_sig, sub_iter,
                                                       &inner_st);
              eldbus_message_iter_container_close(iter, sub_iter);
-             free(sub_sig);
           }
         else if (type[0] == 'v')
           {

-- 


Reply via email to